Use std::filesystem consistentlynightly-2022.07.16
commit3ae72bc22a0d719df6f53e82713c02aa1f47e4ec
authorRick Lavoie <rlavoie@fb.com>
Fri, 15 Jul 2022 23:30:28 +0000 (15 16:30 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Fri, 15 Jul 2022 23:30:28 +0000 (15 16:30 -0700)
treef8c1c96c465c2fc89589d25c8553119d7e4b582f
parentd9e5254e0f665887f8e2e03f0b60f2daec811bcd
Use std::filesystem consistently

Summary:
For filesystem manipulation, we use a mix of boost::filesystem and
folly::fs. However, folly::fs could be boost::filesystem or
std::filesystem depending on which header you include, and we use
both. This means you can get strange compiler errors or linking errors
depending on which headers you include (or what order they're included
in).

Unify around std::filesystem and use that
consistently. boost::filesystem was the prototype for std::filesystem
so most things are just a drop in replacement. Some of the implicit
conversions are gone, and a few methods are renamed/removed. Fix
accordingly.

The only piece of boost::filesystem we still use is unique_path()
because there's no replacement for that in std::filesystem yet.

Reviewed By: mofarrell

Differential Revision: D37876525

fbshipit-source-id: 0e5308de61cb4a28cf0854b51a79f164560753f4
68 files changed:
hphp/compiler/compiler.cpp
hphp/compiler/package.cpp
hphp/compiler/package.h
hphp/hhbbc/debug.cpp
hphp/hhbbc/main.cpp
hphp/runtime/base/autoload-handler.cpp
hphp/runtime/base/autoload-handler.h
hphp/runtime/base/autoload-map.h
hphp/runtime/base/config.cpp
hphp/runtime/base/file-stream-wrapper.cpp
hphp/runtime/base/file-util.cpp
hphp/runtime/base/program-functions.cpp
hphp/runtime/base/repo-autoload-map.cpp
hphp/runtime/base/repo-autoload-map.h
hphp/runtime/base/request-injection-data.cpp
hphp/runtime/base/runtime-option.cpp
hphp/runtime/base/runtime-option.h
hphp/runtime/base/unit-cache.cpp
hphp/runtime/base/unit-cache.h
hphp/runtime/base/user-autoload-map.cpp
hphp/runtime/base/user-autoload-map.h
hphp/runtime/base/watchman-connection.cpp
hphp/runtime/base/watchman-connection.h
hphp/runtime/base/watchman.cpp
hphp/runtime/base/watchman.h
hphp/runtime/ext/facts/attribute-argument-map.h
hphp/runtime/ext/facts/attribute-map.h
hphp/runtime/ext/facts/autoload-db.h
hphp/runtime/ext/facts/ext_facts.cpp
hphp/runtime/ext/facts/fact-extractor.cpp
hphp/runtime/ext/facts/fact-extractor.h
hphp/runtime/ext/facts/facts-store.cpp
hphp/runtime/ext/facts/facts-store.h
hphp/runtime/ext/facts/inheritance-info.h
hphp/runtime/ext/facts/path-and-hash.h
hphp/runtime/ext/facts/path-methods-map.h
hphp/runtime/ext/facts/path-symbols-map.h
hphp/runtime/ext/facts/sqlite-autoload-db.cpp
hphp/runtime/ext/facts/sqlite-autoload-db.h
hphp/runtime/ext/facts/sqlite-key.cpp
hphp/runtime/ext/facts/sqlite-key.h
hphp/runtime/ext/facts/symbol-map.cpp
hphp/runtime/ext/facts/symbol-map.h
hphp/runtime/ext/facts/symbol-types.h
hphp/runtime/ext/facts/test/symbol-map-test.cpp
hphp/runtime/ext/facts/watcher.h
hphp/runtime/ext/facts/watchman-watcher.cpp
hphp/runtime/ext/std/ext_std_file.cpp
hphp/runtime/ext/vsdebug/breakpoint.cpp
hphp/runtime/ext/vsdebug/breakpoint.h
hphp/runtime/ext/vsdebug/debugger.cpp
hphp/runtime/ext/vsdebug/stack_trace_command.cpp
hphp/runtime/server/warmup-request-handler.cpp
hphp/runtime/vm/bytecode.cpp
hphp/runtime/vm/debug/perf-jitdump.cpp
hphp/runtime/vm/decl-provider.cpp
hphp/runtime/vm/decl-provider.h
hphp/runtime/vm/hh-utils.cpp
hphp/runtime/vm/taint/configuration.cpp
hphp/runtime/vm/unit.cpp
hphp/util/blob-encoder.h
hphp/util/cronolog.cpp
hphp/util/extern-worker-detail.h
hphp/util/extern-worker-inl.h
hphp/util/extern-worker.cpp
hphp/util/extern-worker.h
hphp/util/process.cpp
hphp/util/test/extern-worker.cpp