| commit | 3ab677fc44cc0ced787c8d1534ad372da379ec1c | |
| author | Oguz Ulgen <oulgen@fb.com> | |
| Tue, 5 May 2020 18:16:12 +0000 (5 11:16 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Tue, 5 May 2020 18:24:13 +0000 (5 11:24 -0700) | ||
| tree | 9789a0898f425837fd4d8fe4e558607bff397a8e | treesnapshot (tar.gz zip) |
| parent | 10248b2810761a2625af9fe241e83f206530974a | commitdiff |
Optimize idx/ArrayGet for OOB/undefined index on static arrays by keeping a side table
Summary:
This diff adds a side table attached to static ArrayData* in order to quickly check whether an element exists on the ArrayData*. Since make use of bottom bits of hashes, the table can give false positives but never a false negative.
We make use of ArrayAccessProfile to choose when to run this optimization.
Differential Revision: D21026058
fbshipit-source-id: d794cb74a535113088004ae5f8bef2fe779e1bd5
Summary:
This diff adds a side table attached to static ArrayData* in order to quickly check whether an element exists on the ArrayData*. Since make use of bottom bits of hashes, the table can give false positives but never a false negative.
We make use of ArrayAccessProfile to choose when to run this optimization.
Differential Revision: D21026058
fbshipit-source-id: d794cb74a535113088004ae5f8bef2fe779e1bd5
20 files changed: