switch Connection_tracker to immutable
commit394c5ca241c4ff21a015e840a990c80621951e54
authorLucian Wischik <ljw@fb.com>
Thu, 9 Jul 2020 03:40:07 +0000 (8 20:40 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 9 Jul 2020 03:54:39 +0000 (8 20:54 -0700)
treecf41981aad01977ec1542ef2dccd1731d706855c
parentdb5472415358a5d6bc18d2f8ac1bcf79a946c8fa
switch Connection_tracker to immutable

Summary:
2BitSalute asked why Connection_tracker was mutable. It should really have been immutable, like Telemetry.t. So I'm changing it.

Except: I didn't see a good way of threading a monad through all the server code. So I've left ServerClientProvider.client with a mutable field of type Connection_tracker.t

Reviewed By: CatherineGasnier

Differential Revision: D22426926

fbshipit-source-id: 0706c1ac9980e9f166806916762c7695243b970e
hphp/hack/src/client/clientConnect.ml
hphp/hack/src/monitor/monitorConnection.ml
hphp/hack/src/monitor/serverMonitor.ml
hphp/hack/src/server/clientProvider_sig.ml
hphp/hack/src/server/serverClientProvider.ml
hphp/hack/src/server/serverCommand.ml
hphp/hack/src/server/serverMain.ml
hphp/hack/src/server/testClientProvider.ml
hphp/hack/src/utils/connection_tracker.ml
hphp/hack/src/utils/connection_tracker.mli