Add $ in suggession in missing type hint error message
commit391fe504ea1d2b293c99735833ca7b90313b7690
authorMohamed Hegazy <mohegazy@fb.com>
Wed, 3 Aug 2022 14:20:21 +0000 (3 07:20 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Wed, 3 Aug 2022 14:20:21 +0000 (3 07:20 -0700)
tree0caa61a1407ec5de8bb58772a96744bfed424826
parentf49ba7b4d051fab4a6287e751147b005826f64f1
Add $ in suggession in missing type hint error message

Summary:
Add `$` to the suggestion for mising typehints so that it read as:
  `Please add a type hint 'public SomeType $foo'`
instead of
  `Please add a type hint 'public SomeType foo'`

Reviewed By: Wilfred

Differential Revision: D38133144

fbshipit-source-id: cc4e577b32eab6ada27a0fc81f4eebe6f86dd2e2
15 files changed:
hphp/hack/src/errors/naming_error.ml
hphp/hack/test/tast/global_inference/properties/inherit.php.exp
hphp/hack/test/tast/global_inference/properties/type_hint_inferred_property_assignment.php.exp
hphp/hack/test/tast/global_inference/properties/type_hint_inferred_property_constructor.php.exp
hphp/hack/test/tast/global_inference/properties/type_hint_inferred_property_getter.php.exp
hphp/hack/test/tast/global_inference/properties/type_hint_inferred_property_initializer.php.exp
hphp/hack/test/tast/global_inference/properties/type_hint_inferred_property_setter.php.exp
hphp/hack/test/tast/initializer.php.exp
hphp/hack/test/typecheck/call_fty_any.php.exp
hphp/hack/test/typecheck/call_in_static_dict.php.exp
hphp/hack/test/typecheck/call_in_static_dict_like_array.php.exp
hphp/hack/test/typecheck/call_in_static_vec.php.exp
hphp/hack/test/typecheck/call_in_static_vec_like_array.php.exp
hphp/hack/test/typecheck/dynamic_props2.php.exp
hphp/hack/test/typecheck/typing_fail_missing_cv_type.php.exp