| commit | 3807e939bdef463d63e07b40370e5170aea2110d | |
| author | Joel Marcey <joelm@fb.com> | |
| Sat, 3 Aug 2013 00:35:57 +0000 (2 17:35 -0700) | ||
| committer | Sara Golemon <sgolemon@fb.com> | |
| Mon, 5 Aug 2013 21:42:14 +0000 (5 14:42 -0700) | ||
| tree | 9724c15822be31c10bdb4fa165ae3cbc6129143f | treesnapshot (tar.gz zip) |
| parent | e5983c0e98a6a4dd3250e304b355e752221d7219 | commitdiff |
Fuller implementation of get_defined_constants() to support categorization
The PHPUnit test suite calls get_defined_constants(true), for categorization. We threw. Now we don't. Now we actually do something sort of correct, but not fully correct. We have a "user" and "core" constant categorization. Function cleanup and consolidation. That's good. But Zend categorizes even more into extensions. This is a first step. And two (2) tests now move from zend/bad to zend/good.
Differential Revision: D909942
The PHPUnit test suite calls get_defined_constants(true), for categorization. We threw. Now we don't. Now we actually do something sort of correct, but not fully correct. We have a "user" and "core" constant categorization. Function cleanup and consolidation. That's good. But Zend categorizes even more into extensions. This is a first step. And two (2) tests now move from zend/bad to zend/good.
Differential Revision: D909942
12 files changed: