| commit | 374230e678d8742390949d7e7602b465ff182329 | |
| author | Bo Yang <atry@fb.com> | |
| Thu, 11 Aug 2022 21:56:56 +0000 (11 14:56 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 11 Aug 2022 21:56:56 +0000 (11 14:56 -0700) | ||
| tree | 0d2e3c4f23c07df1899d09535981485cac1030b4 | treesnapshot (tar.gz zip) |
| parent | cb6d0e460bcd7d47be1ae69fe6c811121c8352a1 | commitdiff |
Use `*` instead of `\+` in update-first-party.sh (#9143)
Summary:
This PR uses `*` instead of `\+` in `update-first-party.sh` because the BSD `sed` from macOS does not support `\+`, which is not POSIX standard.
Pull Request resolved: https://github.com/facebook/hhvm/pull/9143
Test Plan:
---
https://github.com/facebook/hhvm/issues/9144 is created by the updated version of this script from macOS, which was able to update the hash with `*`, but not with `\+`.
Reviewed By: Wilfred
Differential Revision: D38625879
Pulled By: Atry
fbshipit-source-id: f9b60fe1763fe78039c8a35555215e3bd6424281
Summary:
This PR uses `*` instead of `\+` in `update-first-party.sh` because the BSD `sed` from macOS does not support `\+`, which is not POSIX standard.
Pull Request resolved: https://github.com/facebook/hhvm/pull/9143
Test Plan:
---
https://github.com/facebook/hhvm/issues/9144 is created by the updated version of this script from macOS, which was able to update the hash with `*`, but not with `\+`.
Reviewed By: Wilfred
Differential Revision: D38625879
Pulled By: Atry
fbshipit-source-id: f9b60fe1763fe78039c8a35555215e3bd6424281
| third-party/update-first-party.sh | diffblobblamehistory |