| commit | 363780ee0b3c689127495789629924f26b6074a3 | |
| author | Joseph Griego <jgriego@fb.com> | |
| Wed, 2 Oct 2019 23:25:51 +0000 (2 16:25 -0700) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 2 Oct 2019 23:29:45 +0000 (2 16:29 -0700) | ||
| tree | d131d76225c8cd927427a501530a3e1508c1f598 | treesnapshot (tar.gz zip) |
| parent | 9faf4b4d3fea2afcb590a9d228ff262a1ee75037 | commitdiff |
Fix hhbbc to attribute addelemc const-propp'd dicts correctly
Summary:
We weren't marking the empty array at the start of the chain, so do
that. Also tweaks `provTagHere` to grab the _last_ line of the range instead of
the first--we may want to revisit that if we decide we really want arrprov
marked at the start of an array literal.
Reviewed By: mxw
Differential Revision: D17467778
fbshipit-source-id: 9bd6d672ac5a3a6c971fb77452d1fd1a55268dbb
Summary:
We weren't marking the empty array at the start of the chain, so do
that. Also tweaks `provTagHere` to grab the _last_ line of the range instead of
the first--we may want to revisit that if we decide we really want arrprov
marked at the start of an array literal.
Reviewed By: mxw
Differential Revision: D17467778
fbshipit-source-id: 9bd6d672ac5a3a6c971fb77452d1fd1a55268dbb
| hphp/hhbbc/interp-internal.h | diffblobblamehistory | |
| hphp/hhbbc/interp.cpp | diffblobblamehistory | |
| hphp/hhbbc/type-system.cpp | diffblobblamehistory | |
| hphp/hhbbc/type-system.h | diffblobblamehistory | |
| hphp/test/slow/array_provenance/dict_literal_bug.php | [new file with mode: 0644] | blob |
| hphp/test/slow/array_provenance/dict_literal_bug.php.expectf | [new file with mode: 0644] | blob |
| hphp/test/slow/array_provenance/dict_literal_bug.php.hphp_opts | [new file with mode: 0644] | blob |
| hphp/test/slow/array_provenance/dict_literal_bug.php.opts | [new file with mode: 0644] | blob |