| commit | 35a0f78bb3b9c9e45f29a7610479bf072bccfae4 | |
| author | Kunal Mehta <kunalm@fb.com> | |
| Fri, 18 May 2018 18:46:29 +0000 (18 11:46 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 18 May 2018 19:02:42 +0000 (18 12:02 -0700) | ||
| tree | 6c911b92541d0e9d31347b53f2a443bac9111c97 | treesnapshot (tar.gz zip) |
| parent | bd7ef9194dfc9d61b487d9b93a2743d3edcd1380 | commitdiff |
Refine types in as-expressions
Summary:
This uses the same logic to refine types in as-expressions as we do for is-expressions. We extract `safely_refine_type` into a module-level function and reuse it when typing as-expressions.
We also add some tests that display the nuance of this behavior, such as with wildcards and refinement of individual elements in tuples.
Reviewed By: oulgen
Differential Revision: D8045669
fbshipit-source-id: 1505e3eccae2958b9dcc6c4dd6682dd88f70becc
Summary:
This uses the same logic to refine types in as-expressions as we do for is-expressions. We extract `safely_refine_type` into a module-level function and reuse it when typing as-expressions.
We also add some tests that display the nuance of this behavior, such as with wildcards and refinement of individual elements in tuples.
Reviewed By: oulgen
Differential Revision: D8045669
fbshipit-source-id: 1505e3eccae2958b9dcc6c4dd6682dd88f70becc
24 files changed: