| commit | 35789d162ca01eca1236587e6eb51e4b928b983c | |
| author | Mark Williams <mwilliams@fb.com> | |
| Fri, 29 Jul 2016 14:36:07 +0000 (29 07:36 -0700) | ||
| committer | Hhvm Bot <hhvm-bot-bot@fb.com> | |
| Fri, 29 Jul 2016 14:46:00 +0000 (29 07:46 -0700) | ||
| tree | 7d51dd3bd1705fbde41152e57c0858d6113d57ae | treesnapshot (tar.gz zip) |
| parent | a04ca80fe54f86a6173b2bd0335081231352ab25 | commitdiff |
Fix autoloader crashes
Summary:
We're holding a reference to an element of m_map across a call into
php code (the failure callback), which can modify m_map.
There are a few other mildly scary cases of this in the file, but by
inspection they all seem safe.
Reviewed By: mxw, swtaarrs
Differential Revision: D3636426
fbshipit-source-id: ab4f2c57a747d9514d1d6c5968537fc1cc3acef5
Summary:
We're holding a reference to an element of m_map across a call into
php code (the failure callback), which can modify m_map.
There are a few other mildly scary cases of this in the file, but by
inspection they all seem safe.
Reviewed By: mxw, swtaarrs
Differential Revision: D3636426
fbshipit-source-id: ab4f2c57a747d9514d1d6c5968537fc1cc3acef5
| hphp/runtime/base/autoload-handler.cpp | diffblobblamehistory |