Add `Hole` on 4062 (NonObjectMemberRead) errors
commit35332b6e1f08ca5fec7e9eb2eb49ee7930f4fb69
authorMichael Thomas <mjt@fb.com>
Thu, 26 Aug 2021 14:15:32 +0000 (26 07:15 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 26 Aug 2021 14:17:17 +0000 (26 07:17 -0700)
treebdda3c94602995f23406ce25994d8151341ffcd8
parent722fbc612618db57fa3a69551ff0da872afd7d24
Add `Hole` on 4062 (NonObjectMemberRead) errors

Summary: Add's `Hole`s for method call's on non-object receivers; as with `NullMemberRead`, we can't add a hole for the corresponding property read as the warning is generated during constraint normalisation in subtyping

Reviewed By: madgen

Differential Revision: D30190205

fbshipit-source-id: c0a100b0744c63bbe252a3b023f45a45291aa7b7
13 files changed:
hphp/hack/src/typing/typing.ml
hphp/hack/src/typing/typing_object_get.ml
hphp/hack/src/typing/typing_object_get.mli
hphp/hack/test/holes/HH_FLAGS
hphp/hack/test/holes/non_object_member_read_intersection.php [new file with mode: 0644]
hphp/hack/test/holes/non_object_member_read_intersection.php.holes.exp [new file with mode: 0644]
hphp/hack/test/holes/non_object_member_read_method.php [new file with mode: 0644]
hphp/hack/test/holes/non_object_member_read_method.php.holes.exp [new file with mode: 0644]
hphp/hack/test/holes/non_object_member_read_property.php [new file with mode: 0644]
hphp/hack/test/holes/non_object_member_read_property.php.holes.exp [new file with mode: 0644]
hphp/hack/test/holes/non_object_member_read_union.php [new file with mode: 0644]
hphp/hack/test/holes/non_object_member_read_union.php.holes.exp [new file with mode: 0644]
hphp/hack/test/tast/global_inference/params/type_hint_parameter_indirect.php.exp