| commit | 34fd7cb844a23d5b938bdf207a3dff8ad2ab37d8 | |
| author | Jordan DeLong <jdelong@fb.com> | |
| Sun, 10 Nov 2013 02:33:46 +0000 (9 18:33 -0800) | ||
| committer | Sara Golemon <sgolemon@fb.com> | |
| Tue, 12 Nov 2013 18:24:05 +0000 (12 10:24 -0800) | ||
| tree | 259b8b1a20a71cff3ccf79d73376c1000f2b0d99 | treesnapshot (tar.gz zip) |
| parent | f11209f4c45150fab82a05bacebf72f7dd1f68d2 | commitdiff |
Fix an issue with methodCacheSlowerPath if Fatal == false
After we store the null Func, it was setting an invName on
the ActRec even though it's not a magic call. It would also update
the MCE as if it were magic. I'm not sure if this could've caused a
bug (maybe someone would treat the invName as a VarEnv, since there
should never be an invName on a non-prelive actrec?)
Reviewed By: @bertmaher
Differential Revision: D1050301
After we store the null Func, it was setting an invName on
the ActRec even though it's not a magic call. It would also update
the MCE as if it were magic. I'm not sure if this could've caused a
bug (maybe someone would treat the invName as a VarEnv, since there
should never be an invName on a non-prelive actrec?)
Reviewed By: @bertmaher
Differential Revision: D1050301
| hphp/runtime/vm/bytecode.cpp | diffblobblamehistory | |
| hphp/runtime/vm/jit/target-cache.cpp | diffblobblamehistory |