| commit | 33da4cfb51c4ea4cf15d30418473b7b91a9f4606 | |
| author | Sara Golemon <sgolemon@fb.com> | |
| Tue, 15 Dec 2015 04:43:34 +0000 (14 20:43 -0800) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Tue, 15 Dec 2015 05:00:30 +0000 (14 21:00 -0800) | ||
| tree | 0b7e959e3abdbac0130d3a498b89ebad5ca856b6 | treesnapshot (tar.gz zip) |
| parent | e85dd8505ce45f6bf5a26e1bb1069977353616be | commitdiff |
Fix SOCKET_E* constants
Summary:
The HHVM_RC_INT macro assumes the constant name in the raw,
but REGISTER_LONG_CONSTANT assumes a quoted constant name.
Combining them leaves us with a stringified quotes constant name.
That is, the quotes become part of the name.
Remove use of HHVM_RC_INT() macro and register the constants directly.
Reviewed By: fredemmott, JoelMarcey
Differential Revision: D2757999
fb-gh-sync-id: a51657653c943625404b171ec7a3c054ae33b316
Summary:
The HHVM_RC_INT macro assumes the constant name in the raw,
but REGISTER_LONG_CONSTANT assumes a quoted constant name.
Combining them leaves us with a stringified quotes constant name.
That is, the quotes become part of the name.
Remove use of HHVM_RC_INT() macro and register the constants directly.
Reviewed By: fredemmott, JoelMarcey
Differential Revision: D2757999
fb-gh-sync-id: a51657653c943625404b171ec7a3c054ae33b316
| hphp/runtime/ext/sockets/ext_sockets.cpp | diffblobblamehistory | |
| hphp/test/slow/ext_socket/unix-consts.php | [new file with mode: 0644] | blob |
| hphp/test/slow/ext_socket/unix-consts.php.expectf | [new file with mode: 0644] | blob |