| commit | 325c634ad8eeb6c558cbbfbcd613c5f69c9d934d | |
| author | Thomas Jiang <thomasjiang@fb.com> | |
| Thu, 24 Oct 2019 04:49:48 +0000 (23 21:49 -0700) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 24 Oct 2019 04:53:45 +0000 (23 21:53 -0700) | ||
| tree | 6dcfc7a9fdc497beebb680d28b9ff84ce66431dd | treesnapshot (tar.gz zip) |
| parent | a185852a2cc7393f68a02b8dd5427a2c129cf1fb | commitdiff |
Elaborate meth_caller
Summary:
We currently perform namespace elaboration all over the place - such as in naming and in codegen. If we are able to extract the namespace elaboration into one pass, we can remove having separate logic in naming and codegen and have it all in one place.
The plan is to
1.) Create an endo visitor that performs just namespace elaboration
2.) Move all of the elaboration from naming into it
3.) Add this pass into the codegen pass and see if codegen produces different bytecode
This diff elaborates meth_caller classes
Reviewed By: kmeht
Differential Revision: D17847121
fbshipit-source-id: 04882b031bfdb57f347fdf3dcb976678dac419f6
Summary:
We currently perform namespace elaboration all over the place - such as in naming and in codegen. If we are able to extract the namespace elaboration into one pass, we can remove having separate logic in naming and codegen and have it all in one place.
The plan is to
1.) Create an endo visitor that performs just namespace elaboration
2.) Move all of the elaboration from naming into it
3.) Add this pass into the codegen pass and see if codegen produces different bytecode
This diff elaborates meth_caller classes
Reviewed By: kmeht
Differential Revision: D17847121
fbshipit-source-id: 04882b031bfdb57f347fdf3dcb976678dac419f6
| hphp/hack/src/naming/elaborate_namespaces_endo.ml | diffblobblamehistory | |
| hphp/hack/src/naming/naming.ml | diffblobblamehistory |