| commit | 30b8e6eee74f0baa99d4c425fc8ce10234efd0fc | |
| author | Nick Gavalas <njg@fb.com> | |
| Tue, 19 Dec 2017 22:20:08 +0000 (19 14:20 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Tue, 19 Dec 2017 22:38:25 +0000 (19 14:38 -0800) | ||
| tree | 8c8c2f7a07082c4765201f33ceff76f9cba07bd1 | treesnapshot (tar.gz zip) |
| parent | 27c7373df33195954512a9535e09ccf54479dea3 | commitdiff |
disallow declaring XHP attributes as required with a default
Summary: Like declaring a nullable required attribute, this also doesn't really make sense -- if it's required, how do you ever use the default? This already throws at runtime if you actually don't provide a value (because it's required) and the default part only ever comes into play for non-required attributes.
Reviewed By: usikder
Differential Revision: D6595767
fbshipit-source-id: 0269c292c5093d30558e600b4040dde1314cd44f
Summary: Like declaring a nullable required attribute, this also doesn't really make sense -- if it's required, how do you ever use the default? This already throws at runtime if you actually don't provide a value (because it's required) and the default part only ever comes into play for non-required attributes.
Reviewed By: usikder
Differential Revision: D6595767
fbshipit-source-id: 0269c292c5093d30558e600b4040dde1314cd44f
| hphp/hack/src/naming/naming.ml | diffblobblamehistory | |
| hphp/hack/src/utils/errors/errors.ml | diffblobblamehistory | |
| hphp/hack/src/utils/errors/errors_sig.ml | diffblobblamehistory |