Ban references in strict mode again
commit2fb2baf0e0869e40b971855a24df571561a6dc10
authorMike Qian <mqian@fb.com>
Fri, 22 Jun 2018 04:23:31 +0000 (21 21:23 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Fri, 22 Jun 2018 04:28:21 +0000 (21 21:28 -0700)
treec40cbe17adaa863ba2df9052d99e9d40cf3f439c
parent29dea26fd7c9abc6c5e96c8669695b1f8e34a599
Ban references in strict mode again

Summary: The FFP allowed references to pass through the type checker, so copy the check from the legacy parser to a later phase.

Reviewed By: kmeht

Differential Revision: D8584699

fbshipit-source-id: 97b2d265de1c39b71f6be8e877024453e493b6bd
12 files changed:
hphp/hack/src/errors/error_codes.ml
hphp/hack/src/errors/errors.ml
hphp/hack/src/errors/errors_sig.ml
hphp/hack/src/naming/naming.ml
hphp/hack/test/errors/error_map.ml
hphp/hack/test/typecheck/hh_fixme11.php
hphp/hack/test/typecheck/legacy/strict_reference3.php.exp [deleted file]
hphp/hack/test/typecheck/legacy/use_ref2.php.exp [deleted file]
hphp/hack/test/typecheck/strict_reference3.php [moved from hphp/hack/test/typecheck/legacy/strict_reference3.php with 100% similarity]
hphp/hack/test/typecheck/strict_reference3.php.exp [new file with mode: 0644]
hphp/hack/test/typecheck/use_ref2.php [moved from hphp/hack/test/typecheck/legacy/use_ref2.php with 88% similarity]
hphp/hack/test/typecheck/use_ref2.php.exp [new file with mode: 0644]