| commit | 2ead35b642d4ff3f2f74f5f2ad2f4576202b467c | |
| author | Waleed Khan <waleedk@fb.com> | |
| Fri, 3 May 2019 08:55:46 +0000 (3 01:55 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 3 May 2019 08:59:33 +0000 (3 01:59 -0700) | ||
| tree | a0c3a5b34a2554a317cd2228520d785060df4a10 | treesnapshot (tar.gz zip) |
| parent | 02c902fe3de71404c13fb50a2e2b53e912a1476c | commitdiff |
Back out D14936033 "Write multi-file test cases to disk during testing"
Summary: The backed-out commit changed the signature of the "method jumps" RPC call to return a `Pos.t` instead of a `Pos.absolute`. `Pos.t` uses `Relative_path.t` internally. Relative paths must not be passed across the RPC boundary, because they can only be interpreted with the context of the repo root, which the client does not actually have, but the server does. Previously, the server would always send absolute paths over the RPC layer, which worked.
Reviewed By: andrewjkennedy
Differential Revision: D15193973
fbshipit-source-id: 9a9720ebccdb527cb580cf925a00e42890d30e32
Summary: The backed-out commit changed the signature of the "method jumps" RPC call to return a `Pos.t` instead of a `Pos.absolute`. `Pos.t` uses `Relative_path.t` internally. Relative paths must not be passed across the RPC boundary, because they can only be interpreted with the context of the repo root, which the client does not actually have, but the server does. Previously, the server would always send absolute paths over the RPC layer, which worked.
Reviewed By: andrewjkennedy
Differential Revision: D15193973
fbshipit-source-id: 9a9720ebccdb527cb580cf925a00e42890d30e32
13 files changed: