| commit | 2d8c17614e093fcc2697d6bc572becf742a3f979 | |
| author | Yang, Bo <pop.atry@gmail.com> | |
| Sat, 24 Sep 2022 01:50:55 +0000 (23 18:50 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Sat, 24 Sep 2022 01:50:55 +0000 (23 18:50 -0700) | ||
| tree | d0d841c7e5b8d2c095c34af3bafcfa1f0e7fec4d | treesnapshot (tar.gz zip) |
| parent | 8f2d6f092770fe511add4d99a548c97a8844b094 | commitdiff |
Add -fsized-deallocation compile option (#528)
Summary:
link: https://github.com/facebook/fbthrift/pull/528
Fb-thrift uses C++17's `operator delete`, which requires `-fsized-deallocation` when building c++ source code with clang and libstdc++.
https://github.com/facebook/hhvm/blob/9832791642981d582d0f29c6d89dba2c879cc43d/third-party/thrift/src/thrift/lib/cpp/ContextStack.cpp#L229-L230
Pull Request resolved: https://github.com/facebook/hhvm/pull/9218
Test Plan: Rebase https://github.com/facebook/hhvm/issues/9129 onto this PR, then there will be no error message about `operator delete`.
Reviewed By: vitaut
Differential Revision: D39707592
Pulled By: Atry
fbshipit-source-id: aeddf5d6b2c8bb8b9d71578fe38f57a1b47f8dc9
Summary:
link: https://github.com/facebook/fbthrift/pull/528
Fb-thrift uses C++17's `operator delete`, which requires `-fsized-deallocation` when building c++ source code with clang and libstdc++.
https://github.com/facebook/hhvm/blob/9832791642981d582d0f29c6d89dba2c879cc43d/third-party/thrift/src/thrift/lib/cpp/ContextStack.cpp#L229-L230
Pull Request resolved: https://github.com/facebook/hhvm/pull/9218
Test Plan: Rebase https://github.com/facebook/hhvm/issues/9129 onto this PR, then there will be no error message about `operator delete`.
Reviewed By: vitaut
Differential Revision: D39707592
Pulled By: Atry
fbshipit-source-id: aeddf5d6b2c8bb8b9d71578fe38f57a1b47f8dc9
| third-party/thrift/src/thrift/lib/cpp/CMakeLists.txt | diffblobblamehistory |