| commit | 2cfb1e03708d76da1b0f373ab8d838e282c16acc | |
| author | Mark Williams <mwilliams@fb.com> | |
| Fri, 20 Apr 2018 22:34:39 +0000 (20 15:34 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 20 Apr 2018 22:36:47 +0000 (20 15:36 -0700) | ||
| tree | 37f7dc618943670e1dfe158e577de964f554d842 | treesnapshot (tar.gz zip) |
| parent | e95e089e652f5b786f0fa20e9c4086a881ce7854 | commitdiff |
Cleanup some exec/system issues
Summary:
- get_hhvm_ini_values can use exec to avoid writing to a temp file
- a couple of other places should use exec to avoid writing to the
console
- most uses of exec need to redirect stderr, to avoid writing to
the console
Reviewed By: alexeyt
Differential Revision: D7653551
fbshipit-source-id: 58a45f35446c4f907b4e18a383636776337b777f
Summary:
- get_hhvm_ini_values can use exec to avoid writing to a temp file
- a couple of other places should use exec to avoid writing to the
console
- most uses of exec need to redirect stderr, to avoid writing to
the console
Reviewed By: alexeyt
Differential Revision: D7653551
fbshipit-source-id: 58a45f35446c4f907b4e18a383636776337b777f
| hphp/test/run | diffblobblamehistory |