comment out unused parameters
commit2a6680846f977865e00825bcf56eaf8619fa88f2
authorVictor Gao <vgao@fb.com>
Fri, 21 Jul 2017 21:50:24 +0000 (21 14:50 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Fri, 21 Jul 2017 22:12:32 +0000 (21 15:12 -0700)
tree42e0d5b8febaf2fbd1dbed344ddc2b23f4156ae9
parent93e34408dd1b4fb9a7d50e835474c52579d88848
comment out unused parameters

Summary: This uses `clang-tidy` to comment out unused parameters (in functions, methods and lambdas) in fbcode. Cases that the tool failed to handle are fixed manually.

Reviewed By: igorsugak

Differential Revision: D5454343

fbshipit-source-id: 5dee339b4334e25e963891b519a5aa81fbf627b2
410 files changed:
hphp/compiler/analysis/analysis_result.cpp
hphp/compiler/analysis/block_scope.h
hphp/compiler/analysis/class_scope.cpp
hphp/compiler/analysis/constant_table.cpp
hphp/compiler/analysis/emitter.cpp
hphp/compiler/analysis/function_scope.cpp
hphp/compiler/analysis/variable_table.cpp
hphp/compiler/compiler.cpp
hphp/compiler/construct.h
hphp/compiler/expression/array_element_expression.h
hphp/compiler/expression/assignment_expression.cpp
hphp/compiler/expression/class_expression.cpp
hphp/compiler/expression/constant_expression.cpp
hphp/compiler/expression/constant_expression.h
hphp/compiler/expression/dynamic_variable.h
hphp/compiler/expression/encaps_list_expression.cpp
hphp/compiler/expression/expression.cpp
hphp/compiler/expression/expression.h
hphp/compiler/expression/expression_list.cpp
hphp/compiler/expression/function_call.cpp
hphp/compiler/expression/function_call.h
hphp/compiler/expression/modifier_expression.cpp
hphp/compiler/expression/null_coalesce_expression.cpp
hphp/compiler/expression/object_method_expression.cpp
hphp/compiler/expression/object_property_expression.cpp
hphp/compiler/expression/object_property_expression.h
hphp/compiler/expression/pipe_variable.cpp
hphp/compiler/expression/qop_expression.cpp
hphp/compiler/expression/scalar_expression.cpp
hphp/compiler/expression/simple_variable.cpp
hphp/compiler/expression/static_class_name.cpp
hphp/compiler/expression/static_member_expression.cpp
hphp/compiler/expression/static_member_expression.h
hphp/compiler/expression/unary_op_expression.cpp
hphp/compiler/expression/user_attribute.cpp
hphp/compiler/json.h
hphp/compiler/option.cpp
hphp/compiler/package.cpp
hphp/compiler/parser/parser.cpp
hphp/compiler/parser/parser.h
hphp/compiler/statement/break_statement.cpp
hphp/compiler/statement/class_constant.cpp
hphp/compiler/statement/class_require_statement.cpp
hphp/compiler/statement/class_variable.cpp
hphp/compiler/statement/exp_statement.cpp
hphp/compiler/statement/global_statement.cpp
hphp/compiler/statement/goto_statement.cpp
hphp/compiler/statement/label_statement.cpp
hphp/compiler/statement/statement.cpp
hphp/compiler/statement/statement.h
hphp/compiler/statement/statement_list.cpp
hphp/compiler/statement/static_statement.cpp
hphp/compiler/statement/typedef_statement.cpp
hphp/compiler/statement/unset_statement.cpp
hphp/compiler/statement/use_declaration_statement_fragment.h
hphp/hhbbc/analyze.cpp
hphp/hhbbc/bc.h
hphp/hhbbc/cfg-opts.cpp
hphp/hhbbc/cfg.h
hphp/hhbbc/check.cpp
hphp/hhbbc/dce.cpp
hphp/hhbbc/emit.cpp
hphp/hhbbc/index.cpp
hphp/hhbbc/interp-minstr.cpp
hphp/hhbbc/interp.cpp
hphp/hhbbc/parse.cpp
hphp/hhbbc/stats.cpp
hphp/hhbbc/type-system.cpp
hphp/parser/parser.h
hphp/parser/scanner.cpp
hphp/php7/hhas.cpp
hphp/php7/unit.cpp
hphp/php7/zend/zend.cpp
hphp/ppc64-asm/decoded-instr-ppc64.cpp
hphp/runtime/base/apc-local-array.cpp
hphp/runtime/base/array-data.cpp
hphp/runtime/base/array-data.h
hphp/runtime/base/array-init.h
hphp/runtime/base/array-iterator.cpp
hphp/runtime/base/builtin-functions.cpp
hphp/runtime/base/comparisons.h
hphp/runtime/base/concurrent-shared-store.cpp
hphp/runtime/base/config.cpp
hphp/runtime/base/config.h
hphp/runtime/base/curl-tls-workarounds.cpp
hphp/runtime/base/data-stream-wrapper.cpp
hphp/runtime/base/data-walker.cpp
hphp/runtime/base/debuggable.h
hphp/runtime/base/empty-array.cpp
hphp/runtime/base/empty-array.h
hphp/runtime/base/execution-context-inl.h
hphp/runtime/base/execution-context.cpp
hphp/runtime/base/file-stream-wrapper.cpp
hphp/runtime/base/file-stream-wrapper.h
hphp/runtime/base/file.cpp
hphp/runtime/base/glob-stream-wrapper.cpp
hphp/runtime/base/heap-collect.cpp
hphp/runtime/base/heap-report.cpp
hphp/runtime/base/http-client.cpp
hphp/runtime/base/http-stream-wrapper.cpp
hphp/runtime/base/ini-setting.cpp
hphp/runtime/base/libevent-http-client.cpp
hphp/runtime/base/mem-file.cpp
hphp/runtime/base/member-reflection.h
hphp/runtime/base/mixed-array.cpp
hphp/runtime/base/object-data.cpp
hphp/runtime/base/output-file.cpp
hphp/runtime/base/packed-array.cpp
hphp/runtime/base/perf-mem-event.cpp
hphp/runtime/base/preg.cpp
hphp/runtime/base/program-functions.cpp
hphp/runtime/base/proxy-array.cpp
hphp/runtime/base/rds.cpp
hphp/runtime/base/req-containers.h
hphp/runtime/base/req-malloc.h
hphp/runtime/base/resource-data.h
hphp/runtime/base/runtime-option.cpp
hphp/runtime/base/set-array.cpp
hphp/runtime/base/socket.cpp
hphp/runtime/base/ssl-socket.cpp
hphp/runtime/base/stream-wrapper.h
hphp/runtime/base/temp-file.cpp
hphp/runtime/base/temp-file.h
hphp/runtime/base/thrift-buffer.h
hphp/runtime/base/tv-arith.cpp
hphp/runtime/base/tv-conversions.cpp
hphp/runtime/base/type-array.cpp
hphp/runtime/base/type-string.cpp
hphp/runtime/base/type-string.h
hphp/runtime/base/url-file.cpp
hphp/runtime/base/user-file.cpp
hphp/runtime/base/user-file.h
hphp/runtime/base/zend-collator.cpp
hphp/runtime/base/zend-printf.cpp
hphp/runtime/base/zend-string.cpp
hphp/runtime/debugger/cmd/cmd_complete.cpp
hphp/runtime/debugger/cmd/cmd_continue.cpp
hphp/runtime/debugger/cmd/cmd_extended.cpp
hphp/runtime/debugger/cmd/cmd_flow_control.cpp
hphp/runtime/debugger/cmd/cmd_out.cpp
hphp/runtime/debugger/cmd/cmd_print.cpp
hphp/runtime/debugger/cmd/cmd_run.cpp
hphp/runtime/debugger/cmd/cmd_step.cpp
hphp/runtime/debugger/debugger_base.cpp
hphp/runtime/debugger/debugger_base.h
hphp/runtime/debugger/debugger_client.cpp
hphp/runtime/debugger/debugger_command.cpp
hphp/runtime/debugger/debugger_hook_handler.h
hphp/runtime/debugger/debugger_proxy.cpp
hphp/runtime/ext/apache/ext_apache.cpp
hphp/runtime/ext/apc/ext_apc.cpp
hphp/runtime/ext/async_mysql/ext_async_mysql.cpp
hphp/runtime/ext/bz2/ext_bz2.cpp
hphp/runtime/ext/collections/ext_collections-pair.h
hphp/runtime/ext/collections/ext_collections-set.cpp
hphp/runtime/ext/collections/ext_collections-vector.cpp
hphp/runtime/ext/curl/curl-multi-await.cpp
hphp/runtime/ext/curl/curl-resource.cpp
hphp/runtime/ext/datetime/ext_datetime.h
hphp/runtime/ext/domdocument/ext_domdocument.cpp
hphp/runtime/ext/extension.h
hphp/runtime/ext/factparse/parser.cpp
hphp/runtime/ext/factparse/parser.h
hphp/runtime/ext/fb/VariantController.h
hphp/runtime/ext/fileinfo/ext_fileinfo.cpp
hphp/runtime/ext/fileinfo/libmagic/compress.cpp
hphp/runtime/ext/fileinfo/libmagic/funcs.cpp
hphp/runtime/ext/fileinfo/libmagic/magic.cpp
hphp/runtime/ext/fileinfo/libmagic/print.cpp
hphp/runtime/ext/fileinfo/libmagic/readelf.cpp
hphp/runtime/ext/fileinfo/libmagic/softmagic.cpp
hphp/runtime/ext/filter/ext_filter.cpp
hphp/runtime/ext/filter/sanitizing_filters.cpp
hphp/runtime/ext/gd/ext_gd.cpp
hphp/runtime/ext/gd/libgd/gd_interpolation.cpp
hphp/runtime/ext/gd/libgd/gd_jpeg.cpp
hphp/runtime/ext/gd/libgd/gd_png.cpp
hphp/runtime/ext/gd/libgd/gd_rotate.cpp
hphp/runtime/ext/gd/libgd/gd_ss.cpp
hphp/runtime/ext/gd/libgd/gd_topal.cpp
hphp/runtime/ext/gd/libgd/gdft.cpp
hphp/runtime/ext/gmp/ext_gmp.cpp
hphp/runtime/ext/hotprofiler/ext_hotprofiler.cpp
hphp/runtime/ext/iconv/ext_iconv.cpp
hphp/runtime/ext/icu/ext_icu_break_iterator.cpp
hphp/runtime/ext/icu/ext_icu_date_fmt.cpp
hphp/runtime/ext/icu/ext_icu_uchar.cpp
hphp/runtime/ext/icu/ext_icu_ucsdet.h
hphp/runtime/ext/imagick/imagick.cpp
hphp/runtime/ext/imap/ext_imap.cpp
hphp/runtime/ext/ldap/ext_ldap.cpp
hphp/runtime/ext/libxml/ext_libxml.cpp
hphp/runtime/ext/mailparse/ext_mailparse.cpp
hphp/runtime/ext/mbstring/ext_mbstring.cpp
hphp/runtime/ext/mcrouter/ext_mcrouter.cpp
hphp/runtime/ext/memcache/ext_memcache.cpp
hphp/runtime/ext/memcached/ext_memcached.cpp
hphp/runtime/ext/mysql/ext_mysql.cpp
hphp/runtime/ext/mysql/ext_mysqli.cpp
hphp/runtime/ext/odbc/ext_odbc.cpp
hphp/runtime/ext/pdo/ext_pdo.cpp
hphp/runtime/ext/pdo/pdo_driver.cpp
hphp/runtime/ext/pdo_mysql/pdo_mysql.cpp
hphp/runtime/ext/pdo_sqlite/pdo_sqlite.cpp
hphp/runtime/ext/phar/ext_phar.cpp
hphp/runtime/ext/session/ext_session.cpp
hphp/runtime/ext/simplexml/ext_simplexml.cpp
hphp/runtime/ext/soap/encoding.cpp
hphp/runtime/ext/soap/ext_soap.cpp
hphp/runtime/ext/soap/packet.cpp
hphp/runtime/ext/soap/schema.cpp
hphp/runtime/ext/soap/xml.cpp
hphp/runtime/ext/spl/ext_spl.cpp
hphp/runtime/ext/sqlite3/ext_sqlite3.cpp
hphp/runtime/ext/std/ext_std.h
hphp/runtime/ext/std/ext_std_errorfunc.cpp
hphp/runtime/ext/std/ext_std_file.cpp
hphp/runtime/ext/std/ext_std_function.cpp
hphp/runtime/ext/std/ext_std_misc.cpp
hphp/runtime/ext/std/ext_std_options.cpp
hphp/runtime/ext/std/ext_std_output.cpp
hphp/runtime/ext/std/ext_std_process.cpp
hphp/runtime/ext/stream/ext_stream.cpp
hphp/runtime/ext/string/ext_string.cpp
hphp/runtime/ext/thrift/compact.cpp
hphp/runtime/ext/url/ext_url.cpp
hphp/runtime/ext/watchman/ext_watchman.cpp
hphp/runtime/ext/xdebug/ext_xdebug.cpp
hphp/runtime/ext/xdebug/hook.cpp
hphp/runtime/ext/xdebug/hook.h
hphp/runtime/ext/xdebug/xdebug_command.cpp
hphp/runtime/ext/xdebug/xdebug_profiler.cpp
hphp/runtime/ext/xdebug/xdebug_profiler.h
hphp/runtime/ext/xmlwriter/ext_xmlwriter.cpp
hphp/runtime/ext/xsl/ext_xsl.cpp
hphp/runtime/ext/zip/ext_zip.cpp
hphp/runtime/ext/zlib/ext_zlib.cpp
hphp/runtime/ext_zend_compat/ftp/ftp.cpp
hphp/runtime/ext_zend_compat/oauth/oauth.cpp
hphp/runtime/ext_zend_compat/php-src/Zend/zend_API.cpp
hphp/runtime/ext_zend_compat/php-src/Zend/zend_alloc.cpp
hphp/runtime/ext_zend_compat/php-src/Zend/zend_compile.cpp
hphp/runtime/ext_zend_compat/php-src/Zend/zend_constants.cpp
hphp/runtime/ext_zend_compat/php-src/Zend/zend_execute_API.cpp
hphp/runtime/ext_zend_compat/php-src/Zend/zend_gc.cpp
hphp/runtime/ext_zend_compat/php-src/Zend/zend_hash.cpp
hphp/runtime/ext_zend_compat/php-src/Zend/zend_ini.cpp
hphp/runtime/ext_zend_compat/php-src/Zend/zend_interfaces.cpp
hphp/runtime/ext_zend_compat/php-src/Zend/zend_object_handlers.cpp
hphp/runtime/ext_zend_compat/php-src/Zend/zend_objects.cpp
hphp/runtime/ext_zend_compat/php-src/Zend/zend_objects_API.cpp
hphp/runtime/ext_zend_compat/php-src/Zend/zend_operators.cpp
hphp/runtime/ext_zend_compat/php-src/ext/pcre/php_pcre.cpp
hphp/runtime/ext_zend_compat/php-src/ext/standard/info.cpp
hphp/runtime/ext_zend_compat/php-src/ext/standard/lcg.cpp
hphp/runtime/ext_zend_compat/php-src/ext/standard/var.cpp
hphp/runtime/ext_zend_compat/php-src/main/SAPI.cpp
hphp/runtime/ext_zend_compat/php-src/main/fopen_wrappers.cpp
hphp/runtime/ext_zend_compat/php-src/main/main.cpp
hphp/runtime/ext_zend_compat/php-src/main/streams/plain_wrapper.cpp
hphp/runtime/ext_zend_compat/php-src/main/streams/streams.cpp
hphp/runtime/ext_zend_compat/php-src/main/streams/transports.cpp
hphp/runtime/ext_zend_compat/yaml/parse.cpp
hphp/runtime/server/admin-request-handler.cpp
hphp/runtime/server/cli-server.cpp
hphp/runtime/server/fake-transport.h
hphp/runtime/server/fastcgi/fastcgi-server.cpp
hphp/runtime/server/fastcgi/fastcgi-server.h
hphp/runtime/server/fastcgi/fastcgi-session.cpp
hphp/runtime/server/fastcgi/fastcgi-transport.cpp
hphp/runtime/server/fastcgi/fastcgi-worker.h
hphp/runtime/server/ip-block-map.cpp
hphp/runtime/server/pagelet-server.cpp
hphp/runtime/server/proxygen/proxygen-server.cpp
hphp/runtime/server/proxygen/proxygen-transport.h
hphp/runtime/server/replay-transport.cpp
hphp/runtime/server/server-name-indication.cpp
hphp/runtime/server/server-stats.cpp
hphp/runtime/server/server.h
hphp/runtime/server/takeover-agent.cpp
hphp/runtime/server/transport.h
hphp/runtime/server/virtual-host.cpp
hphp/runtime/server/writer.h
hphp/runtime/server/xbox-server.cpp
hphp/runtime/server/xbox-server.h
hphp/runtime/test/apc.cpp
hphp/runtime/vm/as.cpp
hphp/runtime/vm/blob-helper.h
hphp/runtime/vm/bytecode.cpp
hphp/runtime/vm/class-inl.h
hphp/runtime/vm/class.cpp
hphp/runtime/vm/debug/debug.cpp
hphp/runtime/vm/debug/dwarf.cpp
hphp/runtime/vm/debug/elfwriter.cpp
hphp/runtime/vm/debugger-hook.cpp
hphp/runtime/vm/debugger-hook.h
hphp/runtime/vm/event-hook.cpp
hphp/runtime/vm/func-emitter-inl.h
hphp/runtime/vm/func.cpp
hphp/runtime/vm/globals-array.cpp
hphp/runtime/vm/hhbc.cpp
hphp/runtime/vm/jit/abi-ppc64.h
hphp/runtime/vm/jit/abi-x64.h
hphp/runtime/vm/jit/alias-analysis.cpp
hphp/runtime/vm/jit/alias-class.cpp
hphp/runtime/vm/jit/asm-info.h
hphp/runtime/vm/jit/cfg.cpp
hphp/runtime/vm/jit/check.cpp
hphp/runtime/vm/jit/code-gen-tls-ppc64.h
hphp/runtime/vm/jit/code-gen-tls-x64.h
hphp/runtime/vm/jit/dce.cpp
hphp/runtime/vm/jit/fixup.cpp
hphp/runtime/vm/jit/frame-state.cpp
hphp/runtime/vm/jit/func-guard-arm.cpp
hphp/runtime/vm/jit/func-guard-ppc64.cpp
hphp/runtime/vm/jit/ir-builder.cpp
hphp/runtime/vm/jit/ir-instruction.cpp
hphp/runtime/vm/jit/irgen-basic.cpp
hphp/runtime/vm/jit/irgen-builtin.cpp
hphp/runtime/vm/jit/irgen-call.cpp
hphp/runtime/vm/jit/irgen-interpone.cpp
hphp/runtime/vm/jit/irgen-iter.cpp
hphp/runtime/vm/jit/irgen-minstr.cpp
hphp/runtime/vm/jit/irgen-resumable.cpp
hphp/runtime/vm/jit/irlower-array.cpp
hphp/runtime/vm/jit/irlower-box.cpp
hphp/runtime/vm/jit/irlower-conv.cpp
hphp/runtime/vm/jit/irlower-exception.cpp
hphp/runtime/vm/jit/irlower-inlining.cpp
hphp/runtime/vm/jit/irlower-internal-inl.h
hphp/runtime/vm/jit/irlower-intrinsic.cpp
hphp/runtime/vm/jit/irlower-lookup-cls-func.cpp
hphp/runtime/vm/jit/irlower-lookup-method.cpp
hphp/runtime/vm/jit/irlower-minstr-internal.h
hphp/runtime/vm/jit/irlower-refcount.cpp
hphp/runtime/vm/jit/load-elim.cpp
hphp/runtime/vm/jit/mcgen-translate.cpp
hphp/runtime/vm/jit/memory-effects.cpp
hphp/runtime/vm/jit/minstr-helpers.h
hphp/runtime/vm/jit/mutation.cpp
hphp/runtime/vm/jit/print.cpp
hphp/runtime/vm/jit/refcount-opts.cpp
hphp/runtime/vm/jit/region-hot-block.cpp
hphp/runtime/vm/jit/region-selection.cpp
hphp/runtime/vm/jit/regionize-func.cpp
hphp/runtime/vm/jit/relocation-arm.cpp
hphp/runtime/vm/jit/relocation-ppc64.cpp
hphp/runtime/vm/jit/relocation-x64.cpp
hphp/runtime/vm/jit/simplify.cpp
hphp/runtime/vm/jit/smashable-instr-arm.cpp
hphp/runtime/vm/jit/target-cache.cpp
hphp/runtime/vm/jit/tc-bind.cpp
hphp/runtime/vm/jit/tc-relocate.cpp
hphp/runtime/vm/jit/translate-region.cpp
hphp/runtime/vm/jit/translator.cpp
hphp/runtime/vm/jit/unique-stubs-arm.cpp
hphp/runtime/vm/jit/unique-stubs-ppc64.cpp
hphp/runtime/vm/jit/unique-stubs-x64.cpp
hphp/runtime/vm/jit/unique-stubs.cpp
hphp/runtime/vm/jit/vasm-arm.cpp
hphp/runtime/vm/jit/vasm-check.cpp
hphp/runtime/vm/jit/vasm-copy.cpp
hphp/runtime/vm/jit/vasm-flags.cpp
hphp/runtime/vm/jit/vasm-fold-imms.cpp
hphp/runtime/vm/jit/vasm-internal-inl.h
hphp/runtime/vm/jit/vasm-lower.cpp
hphp/runtime/vm/jit/vasm-ppc64.cpp
hphp/runtime/vm/jit/vasm-print.cpp
hphp/runtime/vm/jit/vasm-prof-branch.cpp
hphp/runtime/vm/jit/vasm-reuse-imm.cpp
hphp/runtime/vm/jit/vasm-simplify-arm.cpp
hphp/runtime/vm/jit/vasm-simplify-ppc64.cpp
hphp/runtime/vm/jit/vasm-simplify-x64.cpp
hphp/runtime/vm/jit/vasm-simplify.cpp
hphp/runtime/vm/jit/vasm-visit.h
hphp/runtime/vm/jit/vasm-x64.cpp
hphp/runtime/vm/jit/vasm-xls.cpp
hphp/runtime/vm/member-operations.cpp
hphp/runtime/vm/member-operations.h
hphp/runtime/vm/native-data.h
hphp/runtime/vm/native-prop-handler.h
hphp/runtime/vm/native.h
hphp/runtime/vm/repo-helpers.cpp
hphp/runtime/vm/reverse-data-map.cpp
hphp/runtime/vm/unit-emitter.cpp
hphp/runtime/vm/unit.cpp
hphp/runtime/vm/verifier/check-func.cpp
hphp/runtime/vm/verifier/pretty.cpp
hphp/test/ext/test_server.cpp
hphp/tools/type-info-gens/gen-type-scanners.cpp
hphp/util/alloc.h
hphp/util/asm-x64.cpp
hphp/util/asm-x64.h
hphp/util/default-ptr.h
hphp/util/disasm.cpp
hphp/util/embedded-vfs.cpp
hphp/util/hfsort.cpp
hphp/util/job-queue.h
hphp/util/light-process.cpp
hphp/util/logger.h
hphp/util/low-ptr.h
hphp/util/managed-arena.cpp
hphp/util/perf-event.cpp
hphp/util/shm-counter.cpp
hphp/util/ssl-init.cpp
hphp/util/test/job-queue-workload.cpp
hphp/util/test/logger.cpp
hphp/util/tiny-vector.h
hphp/util/type-scan.cpp
hphp/vixl/a64/assembler-a64.h