| commit | 29f0c719759e2a5c6791625eff52626756c4641d | |
| author | Alex Malyshev <alexanderm@fb.com> | |
| Thu, 3 Mar 2016 01:36:55 +0000 (2 17:36 -0800) | ||
| committer | Hhvm Bot <hhvm-bot-bot@fb.com> | |
| Thu, 3 Mar 2016 02:00:33 +0000 (2 18:00 -0800) | ||
| tree | e7fa0f2c26caa1c7d800d0a6eb31897288ae56ab | treesnapshot (tar.gz zip) |
| parent | f7586212ed870d335a3e93bffbd730017481cc11 | commitdiff |
Unittest fixes when running with icu-53.1
Summary:Changes to 1810.php - The "UK_UA_ODESSA" locale is named "uk" as of ICU versions
53.1 and 56.1. The "uk-ua_CALIFORNIA@currency=;currency=GRN" locale is not
valid as of 56.1, so it was just removed.
Changes to ucsdet.php - There was a test that asserted EncodingDetector would
find a string invalid, but ended up being valid utf16-be under icu-53.1. Change the string
to something both icu versions think are invalid. EncodingDetector doesn't seem to exist
in php7, so I didn't check it against icu-56.1
Reviewed By: markw65
Differential Revision: D2997664
fb-gh-sync-id: efe325c0b8cd5a8de052ce43f95d8b3289b0b10a
shipit-source-id: efe325c0b8cd5a8de052ce43f95d8b3289b0b10a
Summary:Changes to 1810.php - The "UK_UA_ODESSA" locale is named "uk" as of ICU versions
53.1 and 56.1. The "uk-ua_CALIFORNIA@currency=;currency=GRN" locale is not
valid as of 56.1, so it was just removed.
Changes to ucsdet.php - There was a test that asserted EncodingDetector would
find a string invalid, but ended up being valid utf16-be under icu-53.1. Change the string
to something both icu versions think are invalid. EncodingDetector doesn't seem to exist
in php7, so I didn't check it against icu-56.1
Reviewed By: markw65
Differential Revision: D2997664
fb-gh-sync-id: efe325c0b8cd5a8de052ce43f95d8b3289b0b10a
shipit-source-id: efe325c0b8cd5a8de052ce43f95d8b3289b0b10a
| hphp/test/slow/ext_collator/1810.php | diffblobblamehistory | |
| hphp/test/slow/ext_collator/1810.php.expectf | diffblobblamehistory | |
| hphp/test/slow/ext_icu/ucsdet.php | diffblobblamehistory |