| commit | 298e42ad254b7107adf4178d4ad45a577da0e23a | |
| author | Ted Spence <tspence@fb.com> | |
| Tue, 18 Jun 2019 05:07:02 +0000 (17 22:07 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Tue, 18 Jun 2019 05:10:53 +0000 (17 22:10 -0700) | ||
| tree | e5e719be6cdd3f7567ca8ef310d4c13e81fff144 | treesnapshot (tar.gz zip) |
| parent | 55e1483badac93a909fce7c24391e2d522d5a194 | commitdiff |
Avoid throwing namespace errors casually
Summary:
As discovered in D15794574, namespace errors can be logged to stdout and cause some tests to fail unexpectedly.
Why do we bother logging these errors when they can be trivially corrected?
If the namespace simply hasn't been registered, let's register it.
Reviewed By: 2BitSalute, arxanas
Differential Revision: D15865589
fbshipit-source-id: 99c42db38449a3f875cbe0515fb67d3ee02e37f9
Summary:
As discovered in D15794574, namespace errors can be logged to stdout and cause some tests to fail unexpectedly.
Why do we bother logging these errors when they can be trivially corrected?
If the namespace simply hasn't been registered, let's register it.
Reviewed By: 2BitSalute, arxanas
Differential Revision: D15865589
fbshipit-source-id: 99c42db38449a3f875cbe0515fb67d3ee02e37f9
| hphp/hack/src/search/namespaceSearchService.ml | diffblobblamehistory |