| commit | 28a51932dc5004e489ddedfbda358a77e2bf4057 | |
| author | Michael Colavita <mcolavita@fb.com> | |
| Sat, 12 Sep 2020 04:14:22 +0000 (11 21:14 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Sat, 12 Sep 2020 04:17:47 +0000 (11 21:17 -0700) | ||
| tree | d67894895c17a675be1a67eddbc6c5ff2e8e6444 | treesnapshot (tar.gz zip) |
| parent | 5d5b8fed75a24ed34187a1ecb88c9170abb37c4d | commitdiff |
Make comparison IR ops layout agnostic
Summary:
Make comparison IR ops layout-agnostic by dispatching to the generic ArrayData helper. These ops are relatively cold in strobelight, so we anticipate a negligible perf impact. This allows us to mark the associated bytecodes as layout-agnostic.
To preserve optimizations, keyset comparisons (which do not reenter or throw) are explicitly flagged to still allow DCE and similar optimizations.
Furthermore, the Vec comparison helpers have been removed, and the ArrayData ones have been updated to account for the inconsistent vec/varray comparison behavior until it's migrated safely.
Differential Revision: D23588960
fbshipit-source-id: 88a0b4c08cbe9f64a14e2e26a374db179957cd1c
Summary:
Make comparison IR ops layout-agnostic by dispatching to the generic ArrayData helper. These ops are relatively cold in strobelight, so we anticipate a negligible perf impact. This allows us to mark the associated bytecodes as layout-agnostic.
To preserve optimizations, keyset comparisons (which do not reenter or throw) are explicitly flagged to still allow DCE and similar optimizations.
Furthermore, the Vec comparison helpers have been removed, and the ArrayData ones have been updated to account for the inconsistent vec/varray comparison behavior until it's migrated safely.
Differential Revision: D23588960
fbshipit-source-id: 88a0b4c08cbe9f64a14e2e26a374db179957cd1c
15 files changed: