| commit | 2858ac516b966a92e44035d8e6705fc16e4e8ec7 | |
| author | Shaunak Kishore <kshaunak@fb.com> | |
| Fri, 22 May 2020 10:41:25 +0000 (22 03:41 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 22 May 2020 10:53:28 +0000 (22 03:53 -0700) | ||
| tree | d4d6cbcd5844e3b726d28b29a5a620db9d38863d | treesnapshot (tar.gz zip) |
| parent | 04a732dc8e04e4b9678867d50d11af47b8b6c3f3 | commitdiff |
Eliminate PackedArrayInit in extensions
Summary:
On the continuing quest to eliminate EmptyArray and plain PackedArrays...
Most extension usages of PackedArrayInit / make_packed_array can be converted over to VArrayInit instead. This change is safe other than (possibly) introducing new notices. Here are the exceptions:
1. array_slice doesn't touch string keys in the array. If there may be some, we use a darray.
2. In ext_collections-pair, ToPHPArray must return a plain array (runtime requirement) so we return a MixedArray.
Reviewed By: dneiter
Differential Revision: D21699243
fbshipit-source-id: 6eb21519a88f81aa6d88f6e1bc029c37b6af0b0f
Summary:
On the continuing quest to eliminate EmptyArray and plain PackedArrays...
Most extension usages of PackedArrayInit / make_packed_array can be converted over to VArrayInit instead. This change is safe other than (possibly) introducing new notices. Here are the exceptions:
1. array_slice doesn't touch string keys in the array. If there may be some, we use a darray.
2. In ext_collections-pair, ToPHPArray must return a plain array (runtime requirement) so we return a MixedArray.
Reviewed By: dneiter
Differential Revision: D21699243
fbshipit-source-id: 6eb21519a88f81aa6d88f6e1bc029c37b6af0b0f
14 files changed: