| commit | 2815d6b9781ce2f4b01d4d50719b2520e4c90243 | |
| author | Vassil Mladenov <vmladenov@fb.com> | |
| Tue, 30 Apr 2019 04:33:45 +0000 (29 21:33 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Tue, 30 Apr 2019 04:37:39 +0000 (29 21:37 -0700) | ||
| tree | e4e8ec948ea39823fd2a6481d0adbb845387c286 | treesnapshot (tar.gz zip) |
| parent | 2f195ebbecacbd6698fb1f5e26b8c245f25df2bf | commitdiff |
Synthesize concrete type constants from defaults, fix naming
Summary:
This implements the default behavior of abstract type constants.
```
abstract class A {
abstract const type T = int;
}
class B extends A {
// const type T = int; (implicit) <<<<<<
}
class C extends A {
const type T = string; // normal behavior
}
```
I fixed the naming of the default (before, class A was being named as "A" rather than "\\A") and changed the `ttc_type` to match the `None` of abstract type constants without defaults.
This diff only implements legacy decl of type consts. Doesn't touch class consts or lazy decl.
Reviewed By: Matt-Schellhas
Differential Revision: D14967542
fbshipit-source-id: 9a4c5868c7e8628544ce769727918787ccbc66ae
Summary:
This implements the default behavior of abstract type constants.
```
abstract class A {
abstract const type T = int;
}
class B extends A {
// const type T = int; (implicit) <<<<<<
}
class C extends A {
const type T = string; // normal behavior
}
```
I fixed the naming of the default (before, class A was being named as "A" rather than "\\A") and changed the `ttc_type` to match the `None` of abstract type constants without defaults.
This diff only implements legacy decl of type consts. Doesn't touch class consts or lazy decl.
Reviewed By: Matt-Schellhas
Differential Revision: D14967542
fbshipit-source-id: 9a4c5868c7e8628544ce769727918787ccbc66ae
25 files changed: