| commit | 27938eafe7c4bbd9617d76d482b6f7c098f879bc | |
| author | Liran Nuna <liranuna@fb.com> | |
| Fri, 23 May 2014 23:24:12 +0000 (23 16:24 -0700) | ||
| committer | JoelMarcey <joelm@fb.com> | |
| Fri, 23 May 2014 23:59:14 +0000 (23 16:59 -0700) | ||
| tree | e23b0e91f8be6652e8421c6de6014817866950ee | treesnapshot (tar.gz zip) |
| parent | e90fa38dde7d816bd0c3052f10813099d408a6d9 | commitdiff |
Only define SID when needed
Summary: SID was defined regardless if there was a session or not. PHP only defines it if needed, so should we
Fixes #1915
Fixes #2705
Reviewed By: @fredemmott
Differential Revision: D1337456
Summary: SID was defined regardless if there was a session or not. PHP only defines it if needed, so should we
Fixes #1915
Fixes #2705
Reviewed By: @fredemmott
Differential Revision: D1337456
| hphp/runtime/base/externals.h | diffblobblamehistory | |
| hphp/runtime/ext/session/ext_session.cpp | diffblobblamehistory | |
| hphp/system/idl/constants.idl.json | diffblobblamehistory | |
| hphp/test/slow/defined/sid.php | [new file with mode: 0644] | blob |
| hphp/test/slow/defined/sid.php.expect | [new file with mode: 0644] | blob |
| hphp/test/slow/session/session_id.php | [new file with mode: 0644] | blob |
| hphp/test/slow/session/session_id.php.expect | [new file with mode: 0644] | blob |