| commit | 2670920554dda4f7f3da78fb84987d032fa2c6fd | |
| author | Steve Cao <shiqicao@fb.com> | |
| Wed, 16 Sep 2020 05:18:33 +0000 (15 22:18 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 16 Sep 2020 05:20:50 +0000 (15 22:20 -0700) | ||
| tree | 6eeedbea2b1b23d50c190f1dd7b8e6b5f88ec632 | treesnapshot (tar.gz zip) |
| parent | c4bf05789b2cfd626abeef4e6abf5511480d99bd | commitdiff |
remove unnecessary Ide_parser_cache.with_ide_cache in nastInitCheck
Summary: some functions in `Ide_parser_cache` can only be called when `is_active_ref` is true, otherwise it throws, setting `is_active_ref` to true only if later `Ids_parser_cache` functions will be called later. But `Ast_provider.find_class_in_file` doesn't call any of them, so `Ide_parser_cache.with_ide_cache` is not needed.
Differential Revision: D23701592
fbshipit-source-id: b305ee00837873601c0109857e0507855d3fb3d4
Summary: some functions in `Ide_parser_cache` can only be called when `is_active_ref` is true, otherwise it throws, setting `is_active_ref` to true only if later `Ids_parser_cache` functions will be called later. But `Ast_provider.find_class_in_file` doesn't call any of them, so `Ide_parser_cache.with_ide_cache` is not needed.
Differential Revision: D23701592
fbshipit-source-id: b305ee00837873601c0109857e0507855d3fb3d4
| hphp/hack/src/typing/nastInitCheck.ml | diffblobblamehistory |