| commit | 2662509a08566b8bb5c9d23ae92c41d702cef4aa | |
| author | Lucian Wischik <ljw@fb.com> | |
| Wed, 17 Jul 2019 21:08:27 +0000 (17 14:08 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Wed, 17 Jul 2019 21:33:10 +0000 (17 14:33 -0700) | ||
| tree | 539d5cf99f16b486bbd112854944086d0f761e7a | treesnapshot (tar.gz zip) |
| parent | b226a3653b49c5e1a2899c88694a0c4b76926d43 | commitdiff |
show at least some signal in serverRage
Summary:
I'm looking at bug reports which have "rage" like this:
```
LSP belief of hh_server_state:
[12:28:52.263] [21.888s ago] hh_server ready
[12:28:52.258] [21.893s ago] hh_server typechecking (local)
[12:22:06.356] [427.794s ago] hh_server ready
LSP adapter state: Main_loop
PSTACK 1398850 (main) -
PSTACK 1398611 (monitor) -
```
From this I don't have a read on whether hh_server really truly is alive and responding. Also, the server and monitor logs show a snapshot but still don't tell me if hh_server is alive and responding.
This diff makes hh_server at least contributes something to the log.
(Unrelated: the pstack entries are all empty. I tried at the command-line... pstack truly does give empty output for hh_server at the moment while giving non-empty output for hh_client. Not sure why).
Reviewed By: 2BitSalute
Differential Revision: D16287543
fbshipit-source-id: 54408ba8a9302473e7c6a2ddcb154d0606a7d3b4
Summary:
I'm looking at bug reports which have "rage" like this:
```
LSP belief of hh_server_state:
[12:28:52.263] [21.888s ago] hh_server ready
[12:28:52.258] [21.893s ago] hh_server typechecking (local)
[12:22:06.356] [427.794s ago] hh_server ready
LSP adapter state: Main_loop
PSTACK 1398850 (main) -
PSTACK 1398611 (monitor) -
```
From this I don't have a read on whether hh_server really truly is alive and responding. Also, the server and monitor logs show a snapshot but still don't tell me if hh_server is alive and responding.
This diff makes hh_server at least contributes something to the log.
(Unrelated: the pstack entries are all empty. I tried at the command-line... pstack truly does give empty output for hh_server at the moment while giving non-empty output for hh_client. Not sure why).
Reviewed By: 2BitSalute
Differential Revision: D16287543
fbshipit-source-id: 54408ba8a9302473e7c6a2ddcb154d0606a7d3b4
| hphp/hack/src/server/serverRage.ml | diffblobblamehistory |