| commit | 24ba66671b9f24957aba3e521fe5367769330e37 | |
| author | Mark Williams <mwilliams@fb.com> | |
| Mon, 24 Oct 2016 14:14:07 +0000 (24 07:14 -0700) | ||
| committer | Hhvm Bot <hhvm-bot-bot@fb.com> | |
| Mon, 24 Oct 2016 14:22:59 +0000 (24 07:22 -0700) | ||
| tree | 326e500c204499413a81625eb6f11973d51c4218 | treesnapshot (tar.gz zip) |
| parent | 2ae019064ff27b68ed9366f9211b232353f54db4 | commitdiff |
Fix refable issue with foldable functions
Summary:
The result of a function call is always "refable" - ie it can be
passed to a function expecting a value by reference, even if the
function returns by value. When we constant fold a function call, we
might have to wrap the result to avoid warnings and errors.
Reviewed By: mxw
Differential Revision: D4051062
fbshipit-source-id: 63ccfcf9f689bf42f6a685e0e048189bf8a059d2
Summary:
The result of a function call is always "refable" - ie it can be
passed to a function expecting a value by reference, even if the
function returns by value. When we constant fold a function call, we
might have to wrap the result to avoid warnings and errors.
Reviewed By: mxw
Differential Revision: D4051062
fbshipit-source-id: 63ccfcf9f689bf42f6a685e0e048189bf8a059d2