| commit | 24aba9c501ec1e6a9f4065258d76536747d153e7 | |
| author | Brett Simmers <bsimmers@fb.com> | |
| Mon, 9 Nov 2015 19:41:51 +0000 (9 11:41 -0800) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Mon, 9 Nov 2015 20:00:34 +0000 (9 12:00 -0800) | ||
| tree | cf73e32bce47b13993182423cb35a9e92a08e81c | treesnapshot (tar.gz zip) |
| parent | 4f16f7cfb92f490ff9473cfb034f1120952b1404 | commitdiff |
Promote KindOfStaticString -> KindOfString in Variant::(to|as)StrRef()
Summary: I had to fix the same issue for toArrRef() in my diff that adds
KindOfStaticArray. As far as I can tell, nothing is actually breaking without
this fix, but we can still end up with non-static KindOfStaticStrings.
Reviewed By: markw65
Differential Revision: D2618330
fb-gh-sync-id: 0c7ec09b91d20d1765535d24c04e45eb3507645b
Summary: I had to fix the same issue for toArrRef() in my diff that adds
KindOfStaticArray. As far as I can tell, nothing is actually breaking without
this fix, but we can still end up with non-static KindOfStaticStrings.
Reviewed By: markw65
Differential Revision: D2618330
fb-gh-sync-id: 0c7ec09b91d20d1765535d24c04e45eb3507645b
| hphp/runtime/base/type-variant.h | diffblobblamehistory |