| commit | 247e307f03d1d2d3958da8e5b98953827df68d73 | |
| author | Drew Paroski <andrewparoski@fb.com> | |
| Tue, 15 Jul 2014 02:24:10 +0000 (14 19:24 -0700) | ||
| committer | facebook-github-bot <githubbot@fb.com> | |
| Tue, 15 Jul 2014 02:30:22 +0000 (14 19:30 -0700) | ||
| tree | e625b7d79b8598c68cfce7f22cde5e94b28b46a4 | treesnapshot (tar.gz zip) |
| parent | 74d6a92169daa541948f3f3163fc31881c43dc6d | commitdiff |
Fix crashes related to "new Pair($x, $y)"
Summary: "new Pair" is supposed to throw an exception with any number of arguments,
However, there was a crash when running under hphpd that could happen if
one or more arguments were passed. The problem was that HHVM was raising a
warning and then returning a partially constructed Pair with uninitialized
fields.
This diff fixes the crash by making "new" use a more defensive C++
constructor that initializes all the field, and by making Pair's
__construct() method take any number of args (which ensures that "new Pair"
will always throw an exception no matter how many args are passed).
Reviewed By: @jdelong
Differential Revision: D1432922
Summary: "new Pair" is supposed to throw an exception with any number of arguments,
However, there was a crash when running under hphpd that could happen if
one or more arguments were passed. The problem was that HHVM was raising a
warning and then returning a partially constructed Pair with uninitialized
fields.
This diff fixes the crash by making "new" use a more defensive C++
constructor that initializes all the field, and by making Pair's
__construct() method take any number of args (which ensures that "new Pair"
will always throw an exception no matter how many args are passed).
Reviewed By: @jdelong
Differential Revision: D1432922