| commit | 247a430c6cf25393e2967e85c18048a65082dc04 | |
| author | Bin Liu <binliu@fb.com> | |
| Thu, 7 May 2015 17:43:55 +0000 (7 10:43 -0700) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Thu, 7 May 2015 18:00:43 +0000 (7 11:00 -0700) | ||
| tree | 36c832ec277a2f5256f3b2aee30f28ea2277d3c8 | treesnapshot (tar.gz zip) |
| parent | 88e9ca810d1af78b63cf1668841fa38b2b0a01ba | commitdiff |
Revert "Save an instruction when checking string"
Summary: This reverts commit 572288955410e2f3e96b6eeffe5dff74f381c8b4.
There seems some real regression in CPU time: https://our.intern.facebook.com/intern/perflab/details/1171280?tapage=pages
I think we want to land the change eventually, but after we figure out what was wrong with the cpu time.
Reviewed By: @ottoni
Differential Revision: D2051805
Summary: This reverts commit 572288955410e2f3e96b6eeffe5dff74f381c8b4.
There seems some real regression in CPU time: https://our.intern.facebook.com/intern/perflab/details/1171280?tapage=pages
I think we want to land the change eventually, but after we figure out what was wrong with the cpu time.
Reviewed By: @ottoni
Differential Revision: D2051805
| hphp/runtime/base/datatype.h | diffblobblamehistory | |
| hphp/runtime/base/tv-helpers.h | diffblobblamehistory |