| commit | 2313bdea3c252fe905821ea6fc8012c692c2dac6 | |
| author | Vassil Mladenov <vmladenov@fb.com> | |
| Mon, 4 Jun 2018 19:14:37 +0000 (4 12:14 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Mon, 4 Jun 2018 19:19:16 +0000 (4 12:19 -0700) | ||
| tree | 8f802d4da32dd88e167c92b62d620fef315bc639 | treesnapshot (tar.gz zip) |
| parent | 28e2d94d4f8c6f63607073cb2490b02bfe820d4d | commitdiff |
Retool regex and underscore elimination in lowerer
Summary:
Found a hotspot in perf report related to darrays, moved pMember out of inline, changed unnecessary split ; concat to replace
run_profile results (with vs without change):
huge
User time (seconds): 29.21 vs 31.36
Maximum resident set size (kbytes): 876920 vs 877036
large
User time (seconds): 27.53 vs 30.50
Maximum resident set size (kbytes): 379292 vs 379364
Reviewed By: pittsw
Differential Revision: D8250377
fbshipit-source-id: fd86f24d0467178013dae1fd9807c20acd8ec884
Summary:
Found a hotspot in perf report related to darrays, moved pMember out of inline, changed unnecessary split ; concat to replace
run_profile results (with vs without change):
huge
User time (seconds): 29.21 vs 31.36
Maximum resident set size (kbytes): 876920 vs 877036
large
User time (seconds): 27.53 vs 30.50
Maximum resident set size (kbytes): 379292 vs 379364
Reviewed By: pittsw
Differential Revision: D8250377
fbshipit-source-id: fd86f24d0467178013dae1fd9807c20acd8ec884
| hphp/hack/src/parser/full_fidelity_ast.ml | diffblobblamehistory |