| commit | 225c0a59354c0b2446e7a307d03aaa564e378344 | |
| author | Mark Williams <mwilliams@fb.com> | |
| Tue, 23 Jan 2018 01:34:26 +0000 (22 17:34 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Tue, 23 Jan 2018 02:01:36 +0000 (22 18:01 -0800) | ||
| tree | 399dd217da6fb7df3409ddc1ac20ef82d2f6b266 | treesnapshot (tar.gz zip) |
| parent | 38fa75e0ad42e4dc74349c2889c54a14f2f324f6 | commitdiff |
Fix an overzealous assert
Summary:
There should only be one DefCls (or DefClsNop) per class, but there's
no reason we can't have multiple CreateCl's for a Closure. Hackc does
that for closures in finally blocks, where hhvm just duplicates the
closure; hackc's approach seems better...
Reviewed By: ricklavoie
Differential Revision: D6776396
fbshipit-source-id: 872fe27c758d8723995227e164d6983d7dbca994
Summary:
There should only be one DefCls (or DefClsNop) per class, but there's
no reason we can't have multiple CreateCl's for a Closure. Hackc does
that for closures in finally blocks, where hhvm just duplicates the
closure; hackc's approach seems better...
Reviewed By: ricklavoie
Differential Revision: D6776396
fbshipit-source-id: 872fe27c758d8723995227e164d6983d7dbca994
| hphp/hhbbc/emit.cpp | diffblobblamehistory |