| commit | 22486c786ec576b4977653adf1065df3e86362d2 | |
| author | Dwayne Reeves <dreeves@fb.com> | |
| Fri, 23 Oct 2015 17:47:36 +0000 (23 10:47 -0700) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Fri, 23 Oct 2015 18:00:42 +0000 (23 11:00 -0700) | ||
| tree | 9ae51b7426436b17b4dff0bd757cd384c0b4b39a | treesnapshot (tar.gz zip) |
| parent | 69ac4bd4218746255b079f33b8c8312b073cb582 | commitdiff |
Make Call-time Pass-by-reference a Parse error
Summary: Call-time pass-by-reference is when you use the reference operator & on the
input of a function parameter. For example:
```
$arr = array(1, 2, 3);
array_shift(&$arr);
```
This was deprecated in PHP 5.3 and causes a fatal in 5.4. In PHP 7 this is a
parser error according to https://3v4l.org/W6oDd This is a fatal in HHVM as well.
This diff makes call-time pass-by-reference a parser error in Hack as well
Reviewed By: achow, dabek
Differential Revision: D2566300
fb-gh-sync-id: d3cafea1c15953a05cb479dfd4f7c927a6560c47
Summary: Call-time pass-by-reference is when you use the reference operator & on the
input of a function parameter. For example:
```
$arr = array(1, 2, 3);
array_shift(&$arr);
```
This was deprecated in PHP 5.3 and causes a fatal in 5.4. In PHP 7 this is a
parser error according to https://3v4l.org/W6oDd This is a fatal in HHVM as well.
This diff makes call-time pass-by-reference a parser error in Hack as well
Reviewed By: achow, dabek
Differential Revision: D2566300
fb-gh-sync-id: d3cafea1c15953a05cb479dfd4f7c927a6560c47
12 files changed: