| commit | 21c41a453f0ecfbc7f0ee0471c3018905b77f243 | |
| author | Jordan DeLong <jdelong@fb.com> | |
| Thu, 8 Jan 2015 19:14:07 +0000 (8 11:14 -0800) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Fri, 23 Jan 2015 01:49:58 +0000 (22 17:49 -0800) | ||
| tree | c2143e497ce7da02ecc10c587e1dfb3d03861244 | treesnapshot (tar.gz zip) |
| parent | f4b285517d1f06ddb55717fd348234d936d233f2 | commitdiff |
Fix some problems with HHIR generic memory ops that take C(Int) sources
Summary: The pointee() function was ignoring possible offsets, so just refactor
things so we always use offset zero with these. Also add a DbgTrashMem. (I
noticed this problem partially through adding that.) The packedarray functions
were handling it properly. LdElem and StElem are used with non-constant
integer offsets---I want to replace them with a new typed-lea and StMem/LdMem,
but for this diff just make them not incorrect they way they are.
Reviewed By: @alexmalyshev
Differential Revision: D1772985
Summary: The pointee() function was ignoring possible offsets, so just refactor
things so we always use offset zero with these. Also add a DbgTrashMem. (I
noticed this problem partially through adding that.) The packedarray functions
were handling it properly. LdElem and StElem are used with non-constant
integer offsets---I want to replace them with a new typed-lea and StMem/LdMem,
but for this diff just make them not incorrect they way they are.
Reviewed By: @alexmalyshev
Differential Revision: D1772985
15 files changed: