| commit | 2198d1a03b498c2de5c20187001be27f01d206ac | |
| author | qigao <gao@fb.com> | |
| Wed, 17 Aug 2011 17:38:51 +0000 (17 10:38 -0700) | ||
| committer | macvicar <macvicar@fb.com> | |
| Fri, 19 Aug 2011 22:58:12 +0000 (19 15:58 -0700) | ||
| tree | 8d763f6011378c95672086977fe8289efea935f7 | treesnapshot (tar.gz zip) |
| parent | bfbfec07afaa504eca7f3cc89f78663174608f48 | commitdiff |
[Fix/hphpd] do not strip quotes around arguments
Summary:
When hphpd parses the command, it tries to strip out the quotes
around the arguments, which could cause broken strings and unexpected
behavior. This diff makes it not stripping out the quotes.
Test Plan:
make fast_tests
hphpd> p strpos("abcdef", "cd")
int(2)
The following won't work anymore
hphpd> i "array_slice"
(specified symbol cannot be found)
But
hphpd> i array_slice
still works
Reviewed By: myang
Reviewers: myang, hzhao
Commenters: rmcelroy
CC: gregschechte, ps, mwilliams, rmcelroy, myang
Revert Plan:
Tags:
- begin *PUBLIC* platform impact section -
Bugzilla: #
- end platform impact -
Differential Revision: 306038
Task ID: 665743
Summary:
When hphpd parses the command, it tries to strip out the quotes
around the arguments, which could cause broken strings and unexpected
behavior. This diff makes it not stripping out the quotes.
Test Plan:
make fast_tests
hphpd> p strpos("abcdef", "cd")
int(2)
The following won't work anymore
hphpd> i "array_slice"
(specified symbol cannot be found)
But
hphpd> i array_slice
still works
Reviewed By: myang
Reviewers: myang, hzhao
Commenters: rmcelroy
CC: gregschechte, ps, mwilliams, rmcelroy, myang
Revert Plan:
Tags:
- begin *PUBLIC* platform impact section -
Bugzilla: #
- end platform impact -
Differential Revision: 306038
Task ID: 665743
| src/runtime/eval/debugger/debugger_client.cpp | diffblobblamehistory |