| commit | 218bf448251e74a18f33a5d221f8a7ce58ecdb82 | |
| author | Edwin Smith <smith@fb.com> | |
| Thu, 4 Feb 2016 15:48:15 +0000 (4 07:48 -0800) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Thu, 4 Feb 2016 16:00:43 +0000 (4 08:00 -0800) | ||
| tree | cb15711ce40aa002ab213fa1cf0817c4158ae730 | treesnapshot (tar.gz zip) |
| parent | 915c90eb173d8ab08d187c6d08f869e5a4a568a8 | commitdiff |
Only check for !pc on haltable instructions
Summary:
Add a constexpr instrCanHalt() predicate, which should optimize
away when called with a constexpr argument. This way we don't
bother checking !pc for opcodes that never halt. This should
reduce some of the boilerplate in interpreter instruction bodies.
Reviewed By: jasone
Differential Revision: D2884620
fb-gh-sync-id: 485ee97f24eef9dd3bc0757f66642e20de42f2d7
Summary:
Add a constexpr instrCanHalt() predicate, which should optimize
away when called with a constexpr argument. This way we don't
bother checking !pc for opcodes that never halt. This should
reduce some of the boilerplate in interpreter instruction bodies.
Reviewed By: jasone
Differential Revision: D2884620
fb-gh-sync-id: 485ee97f24eef9dd3bc0757f66642e20de42f2d7
| hphp/runtime/vm/bytecode.cpp | diffblobblamehistory | |
| hphp/runtime/vm/hhbc.h | diffblobblamehistory |