| commit | 2174b8899e2621232137e2861b30e09434d3a55a | |
| author | Lucian Wischik <ljw@fb.com> | |
| Sun, 18 Jul 2021 20:21:37 +0000 (18 13:21 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Sun, 18 Jul 2021 20:23:19 +0000 (18 13:23 -0700) | ||
| tree | f99825a7d17157db44e9a0c4adf3d74d3065dd08 | treesnapshot (tar.gz zip) |
| parent | 6be2c6c011ad3dd1767787dcd36172470ab159ad | commitdiff |
5/7 rename Naming_sqlite API
Summary:
Reviewer instructions: start with naming_sqlite.mli. The rest of the changes just follow straightforwardly from there. What this diff does:
1. rename get_type_pos -> get_type_pos_by_name
2. rename get_type_paths_by_dep_hash -> get_type_pos_by_64bit_dep
3. likewise renaming Naming_table.get_dep_set_files -> get_64bit_dep_set_files
4. Changed the behavior of get_dep_set_files... Before any of this diffstack, it used to work fine if you gave it Mode.Hash32Bit deps. As of earlier in the diffstack, it started to silently fail to find matches (or to find wrong matches) if you gave it 32bit dephashes. As of this current diffstack, it actively throws an exception if you give it 32bit dephashes.
Reviewed By: CatherineGasnier
Differential Revision: D28903148
fbshipit-source-id: eb1fdd47d64ecbef4ed8bc9adfbab8379bef6e87
Summary:
Reviewer instructions: start with naming_sqlite.mli. The rest of the changes just follow straightforwardly from there. What this diff does:
1. rename get_type_pos -> get_type_pos_by_name
2. rename get_type_paths_by_dep_hash -> get_type_pos_by_64bit_dep
3. likewise renaming Naming_table.get_dep_set_files -> get_64bit_dep_set_files
4. Changed the behavior of get_dep_set_files... Before any of this diffstack, it used to work fine if you gave it Mode.Hash32Bit deps. As of earlier in the diffstack, it started to silently fail to find matches (or to find wrong matches) if you gave it 32bit dephashes. As of this current diffstack, it actively throws an exception if you give it 32bit dephashes.
Reviewed By: CatherineGasnier
Differential Revision: D28903148
fbshipit-source-id: eb1fdd47d64ecbef4ed8bc9adfbab8379bef6e87