| commit | 2113b776fd5d3f6e4a9616525d9c454b8ad7d139 | |
| author | Paul Bissonnette <paulbiss@fb.com> | |
| Thu, 16 Apr 2020 17:01:27 +0000 (16 10:01 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 16 Apr 2020 17:04:25 +0000 (16 10:04 -0700) | ||
| tree | d0f1f97920746634d08876ae38c419173d5ea1f5 | treesnapshot (tar.gz zip) |
| parent | fb69ddef434a3a46a32c411f24e53a7be5ab4242 | commitdiff |
Fail repo builds that encounter assembler errors
Summary: We fatal production builds when we encounter verification errors after compilation or optimization, but we silently generate fatal units for assembler errors, hackc errors (places the `failwith` assertion is used), and any transient or configuration based system errors (e.g. failures during IPC between hackc and hhvm).
Reviewed By: ricklavoie, jano, alexeyt
Differential Revision: D20967480
fbshipit-source-id: f974ccb37d3b8612daa7f0f71318da107a7ea353
Summary: We fatal production builds when we encounter verification errors after compilation or optimization, but we silently generate fatal units for assembler errors, hackc errors (places the `failwith` assertion is used), and any transient or configuration based system errors (e.g. failures during IPC between hackc and hhvm).
Reviewed By: ricklavoie, jano, alexeyt
Differential Revision: D20967480
fbshipit-source-id: f974ccb37d3b8612daa7f0f71318da107a7ea353
| hphp/compiler/package.cpp | diffblobblamehistory | |
| hphp/runtime/base/runtime-option.h | diffblobblamehistory | |
| hphp/runtime/vm/extern-compiler.cpp | diffblobblamehistory | |
| hphp/runtime/vm/extern-compiler.h | diffblobblamehistory | |
| hphp/test/slow/memory/large-scalar-fatal.php.hhbbc_assert | [new file with mode: 0644] | blob |
| hphp/test/slow/memory/large-scalar-fatal.php.hhbbc_opts | [new file with mode: 0644] | blob |
| hphp/test/slow/memory/large-scalar-keys-fatal.php.hhbbc_assert | [new file with mode: 0644] | blob |
| hphp/test/slow/memory/large-scalar-keys-fatal.php.hhbbc_opts | [new file with mode: 0644] | blob |