| commit | 210ab4abd55bf7bc5b52290d2f3e5022f072247d | |
| author | Vladimir Matveev <vladima@fb.com> | |
| Tue, 14 Aug 2018 04:03:59 +0000 (13 21:03 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Tue, 14 Aug 2018 04:32:05 +0000 (13 21:32 -0700) | ||
| tree | d36a29f90ab35b9bc1a2faecb5708cc95d9c5eab | treesnapshot (tar.gz zip) |
| parent | 8b918033f703eff8d3bb5842802498ec536d669b | commitdiff |
Allow reactivity of the function to be determined from the reactivity of lambda arguments
Summary:
As in title.
Prior to this diff we used to interpret `__OnlyRxIfRxFunc` as a condition that must be satisfied at the call site in order for function call to be treated as reactive. With this diff interpretation is different: if function has parameter annotated with `__AtMostRxAsRxFunc` attribute - this means that effective reactivity of the function at its callsite will be determined by taking common upper bound of declared function reactivity and reactivity of arguments that correspond to parameters annotated with `__AtMostRxAsRxFunc`.
Reviewed By: jamesjwu
Differential Revision: D9239324
fbshipit-source-id: 2c548a92e60a581a14b0013888d6538fb7221355
Summary:
As in title.
Prior to this diff we used to interpret `__OnlyRxIfRxFunc` as a condition that must be satisfied at the call site in order for function call to be treated as reactive. With this diff interpretation is different: if function has parameter annotated with `__AtMostRxAsRxFunc` attribute - this means that effective reactivity of the function at its callsite will be determined by taking common upper bound of declared function reactivity and reactivity of arguments that correspond to parameters annotated with `__AtMostRxAsRxFunc`.
Reviewed By: jamesjwu
Differential Revision: D9239324
fbshipit-source-id: 2c548a92e60a581a14b0013888d6538fb7221355
50 files changed: