Move __Deprecated arity error into NAST check
commit1c9f1146fe10c577cf9f988e557773a07a1717d6
authorMillie Chen <milliechen@fb.com>
Mon, 14 Sep 2020 22:53:07 +0000 (14 15:53 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Mon, 14 Sep 2020 22:56:45 +0000 (14 15:56 -0700)
tree7d88c92cc326a1fbca15ad8bbaecb14586b40ea7
parent1a8732df48688fbcfae6f63ccc380c1f38a43cfb
Move __Deprecated arity error into NAST check

Summary:
To unblock direct decl parser, errors emitted during declaration should be moved to NAST check.

 Decl.fun_decl throws an error when the __Deprecated attribute has the wrong arity. Move this error into NAST check to avoid error detection during declaration.

Reviewed By: dabek

Differential Revision: D23659117

fbshipit-source-id: 92343c631cdea56b9fe6c2896943284580842247
hphp/hack/src/decl/decl.ml
hphp/hack/src/naming/dune
hphp/hack/src/naming/naming_attributes_deprecated.ml
hphp/hack/src/typing/nast_check/attribute_arity_check.ml
hphp/hack/src/typing/nast_check/dune
hphp/hack/src/typing/typing_toplevel.ml