| commit | 1b07b237cdd9136140b87016a0e1d012b0414613 | |
| author | Alexey Toptygin <alexeyt@fb.com> | |
| Fri, 23 Apr 2021 01:28:25 +0000 (22 18:28 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 23 Apr 2021 01:31:35 +0000 (22 18:31 -0700) | ||
| tree | c7a22b3103f16fb85f20d7a84c8aeb91630f49ad | treesnapshot (tar.gz zip) |
| parent | fd2a0fb1d211e8348ccfa1f6e86d54968232e6eb | commitdiff |
Fix skipifs and broken tests of the icu extension
Summary: All the tests in hphp/test/slow/ext_icu/icu_49 and hphp/test/slow/ext_icu/icu_latest were skipping due to skipifs with toplevel code. Furthermore, these directories contain the same tests, but with expectations for different versions of icu. We have `INTL_ICU_VERSION === "53.1"` so the icu_49 would never run even with fixed skipifs. Delete hphp/test/slow/ext_icu/icu_49, move the contents of hphp/test/slow/ext_icu/icu_latest into the parent dir, stop checking the version and fix the part of the skipif logic that isn't redundant (hphp/test/slow/ext_icu/skip_unless_locale_fa_IR_present.inc).
Reviewed By: ricklavoie
Differential Revision: D27938045
fbshipit-source-id: 9ffb3e2c4b0f02e6fb677454e5efb3c3e1c272a1
Summary: All the tests in hphp/test/slow/ext_icu/icu_49 and hphp/test/slow/ext_icu/icu_latest were skipping due to skipifs with toplevel code. Furthermore, these directories contain the same tests, but with expectations for different versions of icu. We have `INTL_ICU_VERSION === "53.1"` so the icu_49 would never run even with fixed skipifs. Delete hphp/test/slow/ext_icu/icu_49, move the contents of hphp/test/slow/ext_icu/icu_latest into the parent dir, stop checking the version and fix the part of the skipif logic that isn't redundant (hphp/test/slow/ext_icu/skip_unless_locale_fa_IR_present.inc).
Reviewed By: ricklavoie
Differential Revision: D27938045
fbshipit-source-id: 9ffb3e2c4b0f02e6fb677454e5efb3c3e1c272a1
17 files changed: