Allow disposable constructor access to properties on this
commit1a8f70bc60c2859a984401670d82ab5cb94e6603
authorAndrew Kennedy <akenn@fb.com>
Sat, 9 Dec 2017 00:05:10 +0000 (8 16:05 -0800)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Sat, 9 Dec 2017 00:20:16 +0000 (8 16:20 -0800)
tree9ced24dd2604187837ce7cb4fb53550a4f0fdc97
parente11c3a7179316407aaa7f51ec74f10848fad199f
Allow disposable constructor access to properties on this

Summary:
The promoted properties on a `__construct` method in a disposable type weren't accessible through `$this` because they are "fake members". This is now fixed.

Also support passing disposables to built-in functions such as `echo` and pseudo-functions such as `hh_show`.

Reviewed By: KendallHopkins

Differential Revision: D6519114

fbshipit-source-id: 5ad7e8d0ebb8cea882041176c78bb45c0520a966
hphp/hack/src/hh_single_type_check.ml
hphp/hack/src/typing/typing.ml
hphp/hack/test/typecheck/using/using_good.php