| commit | 1907baaf05c703b54d71ee4758de29b3bd55d035 | |
| author | Jan Oravec <jan@fb.com> | |
| Thu, 3 Oct 2019 00:44:18 +0000 (2 17:44 -0700) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 3 Oct 2019 00:47:09 +0000 (2 17:47 -0700) | ||
| tree | 58767906fa5c48cb20fb376b5d98090bf2a962ed | treesnapshot (tar.gz zip) |
| parent | 88f773817565b993fe710a0abf906b70ca13c265 | commitdiff |
Split stack alias class of CallEffects into inputs, actrec and outputs
Summary:
CallEffects is conflating three separate alias classes together, so split
the `stack` alias class into:
- `inputs` (arguments, unpack, generics): the callee reads them
- `actrec`: the instruction writes it, but the write is currently modeled via SpillFrame, so we pretend to read it
- `outputs` (inout): the callee writes it
- `kills`: this already exists, but was also part of the `stack`
This diff also fixes handling of `outputs`, allowing store-elim to move
NullUninit writes for inout to the catch.
It also provides sufficient enough granularity to kill SpillFrame.
Reviewed By: markw65
Differential Revision: D17709363
fbshipit-source-id: 1c83dbd2a02143c280474b3a863099006f982062
Summary:
CallEffects is conflating three separate alias classes together, so split
the `stack` alias class into:
- `inputs` (arguments, unpack, generics): the callee reads them
- `actrec`: the instruction writes it, but the write is currently modeled via SpillFrame, so we pretend to read it
- `outputs` (inout): the callee writes it
- `kills`: this already exists, but was also part of the `stack`
This diff also fixes handling of `outputs`, allowing store-elim to move
NullUninit writes for inout to the catch.
It also provides sufficient enough granularity to kill SpillFrame.
Reviewed By: markw65
Differential Revision: D17709363
fbshipit-source-id: 1c83dbd2a02143c280474b3a863099006f982062