Remove case insensitivity for special names in emit_expression
commit18ac1db14a4ebcf917c3cec22fb464c848346636
authorThomas Jiang <thomasjiang@fb.com>
Mon, 4 Nov 2019 18:26:39 +0000 (4 10:26 -0800)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Mon, 4 Nov 2019 18:28:51 +0000 (4 10:28 -0800)
tree006fb4f02f6dab9bae19da7793109dbadc74ce18
parentdc89f72cc9d7bd88124c2d8df2927652ab5a5891
Remove case insensitivity for special names in emit_expression

Summary:
Currently, parts of the codegen are case insensitive. For instance, in emit_expression, we happily emit bytecode for invariant, assert, sequence, case insensitively.

This diff changes the behavior to now be case sensitive. `hh\fun` now no longer works as it must be `HH\fun`

Reviewed By: kmeht

Differential Revision: D18228264

fbshipit-source-id: 8f06ce61e2cf7c8bbde5715f1149dd89c8165f37
hphp/hack/src/hhbc/emit_expression.ml
hphp/test/slow/case_sensitive_functions.php [new file with mode: 0644]
hphp/test/slow/case_sensitive_functions.php.expectf [new file with mode: 0644]
hphp/test/slow/func-ptr/func-cast.php
hphp/test/slow/func-ptr/func-convert.php
hphp/test/slow/func-ptr/func-return.php
hphp/test/slow/func-ptr/func-warn.php
hphp/test/slow/global_func/class_meth/dv_arr/mutate.php
hphp/test/slow/global_func/class_meth/dv_arr_hack_arr/call_user_func.php
hphp/test/slow/global_func/class_meth/dv_arr_hack_arr/mutate.php
hphp/test/slow/global_func/class_meth/is_callable.php