| commit | 1894be4219fab02ce48d266c18b5c87d74a14061 | |
| author | Zeyi (Rice) Fan <zeyi@fb.com> | |
| Sat, 8 Oct 2022 02:00:25 +0000 (7 19:00 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Sat, 8 Oct 2022 02:00:25 +0000 (7 19:00 -0700) | ||
| tree | 80a1c57b91ba00d5673be0da9c795340d3ab7f40 | treesnapshot (tar.gz zip) |
| parent | 7d5b739e0c5f006c2f05dda55a3af23dcd020c6d | commitdiff |
rage: rename reporter to stream
Summary:
My original plan was to expand reporter to take on the responsibility of reporting progress, but it turned out Rust borrow checker is not happy about this deign since I need `write!(stream)` to work, which requires a mutable reference while keeping an immutable reference in `StepGuard` I added later.
As a result I have to add the progress reporting struct directly to `WatchmanRage`. This diff just rename `Reporter` to `Stream` to better reflect what it does.
Reviewed By: MichaelCuevas
Differential Revision: D39187638
fbshipit-source-id: 1e7a0d624978f5a5e5c52f435cf15745db8e3721
Summary:
My original plan was to expand reporter to take on the responsibility of reporting progress, but it turned out Rust borrow checker is not happy about this deign since I need `write!(stream)` to work, which requires a mutable reference while keeping an immutable reference in `StepGuard` I added later.
As a result I have to add the progress reporting struct directly to `WatchmanRage`. This diff just rename `Reporter` to `Stream` to better reflect what it does.
Reviewed By: MichaelCuevas
Differential Revision: D39187638
fbshipit-source-id: 1e7a0d624978f5a5e5c52f435cf15745db8e3721