| commit | 1849ab95feaf28b8ad4e8db5eeacd328043408d3 | |
| author | Bill Fumerola <bill@fb.com> | |
| Fri, 14 Sep 2018 14:40:42 +0000 (14 07:40 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 14 Sep 2018 14:42:31 +0000 (14 07:42 -0700) | ||
| tree | 166372659815d1fe97759a9ebda817b7df88517c | treesnapshot (tar.gz zip) |
| parent | 6e7694534768b2474700837c8813a006db8de774 | commitdiff |
fb_compact_unserialize: raise notice for invalid vector
Summary:
add a gated runtime option to complain about any compacted data which contains an invalid skip code inside a vector.
the "specification" docblock does not state this is valid, but our implementation allows it.
hhvm does not produce these vector codes, so the only implementation that could have used skip inside a vector is outside implementations.
Reviewed By: ricklavoie
Differential Revision: D9646688
fbshipit-source-id: c1ec2df71c77c598d1b871a8677fb152fd416861
Summary:
add a gated runtime option to complain about any compacted data which contains an invalid skip code inside a vector.
the "specification" docblock does not state this is valid, but our implementation allows it.
hhvm does not produce these vector codes, so the only implementation that could have used skip inside a vector is outside implementations.
Reviewed By: ricklavoie
Differential Revision: D9646688
fbshipit-source-id: c1ec2df71c77c598d1b871a8677fb152fd416861