| commit | 168058253fc2e0f58195f199478c268406ef5609 | |
| author | Rick Lavoie <rlavoie@fb.com> | |
| Thu, 1 Sep 2016 04:51:07 +0000 (31 21:51 -0700) | ||
| committer | Hhvm Bot <hhvm-bot-bot@fb.com> | |
| Thu, 1 Sep 2016 05:07:55 +0000 (31 22:07 -0700) | ||
| tree | ef6519c09c57e169e4ef193cbdae2958334e42e1 | treesnapshot (tar.gz zip) |
| parent | 8b9becd62322a9bd0788cee89a4ef758a7188be7 | commitdiff |
Fix some HHBBC bugs
Summary:
Fix some Hack array related HHBBC bugs:
- Add a missing return which was causing us to pop too many elements off the
stack.
- We weren't handling keyset in some of the minstr return type handling.
- Fix some strange logic which was confusing the key in a SetM with the
value. This was causing setting an array inside a dict to be marked as
unreachable.
Reviewed By: paulbiss
Differential Revision: D3802745
fbshipit-source-id: 77995028a6f704abb354de11a2e9d39a07f999fc
Summary:
Fix some Hack array related HHBBC bugs:
- Add a missing return which was causing us to pop too many elements off the
stack.
- We weren't handling keyset in some of the minstr return type handling.
- Fix some strange logic which was confusing the key in a SetM with the
value. This was causing setting an array inside a dict to be marked as
unreachable.
Reviewed By: paulbiss
Differential Revision: D3802745
fbshipit-source-id: 77995028a6f704abb354de11a2e9d39a07f999fc
| hphp/hhbbc/interp-minstr.cpp | diffblobblamehistory | |
| hphp/test/slow/dict/hhbbc-group.php | [new file with mode: 0644] | blob |
| hphp/test/slow/dict/hhbbc-group.php.expect | [new file with mode: 0644] | blob |