Remove const on Variant& from setRef and appendRef functions
commit148ddbf3d3649d1b9be31f6f26279f87aa01c887
authorJordan DeLong <jdelong@fb.com>
Mon, 7 Apr 2014 18:00:02 +0000 (7 11:00 -0700)
committerSara Golemon <sgolemon@fb.com>
Wed, 9 Apr 2014 16:47:19 +0000 (9 09:47 -0700)
treeba9cb8eb5bfa01033c574f03d04758a1847cf3c9
parentd47e90c9fc7e5e1c3b909441155a82c5e4b49792
Remove const on Variant& from setRef and appendRef functions

They modify the variant (convert it to KindOfRef), which
isn't what "const" means.  Likely historically used to be able to bind
to temporaries.

Reviewed By: @ptarjan

Differential Revision: D1262400
32 files changed:
hphp/runtime/base/apc-local-array.cpp
hphp/runtime/base/apc-local-array.h
hphp/runtime/base/array-data-defs.h
hphp/runtime/base/array-data.cpp
hphp/runtime/base/array-data.h
hphp/runtime/base/array-init.h
hphp/runtime/base/array-iterator.h
hphp/runtime/base/empty-array.cpp
hphp/runtime/base/empty-array.h
hphp/runtime/base/ini-setting.cpp
hphp/runtime/base/mixed-array-defs.h
hphp/runtime/base/mixed-array.cpp
hphp/runtime/base/mixed-array.h
hphp/runtime/base/object-data.cpp
hphp/runtime/base/object-data.h
hphp/runtime/base/packed-array.cpp
hphp/runtime/base/packed-array.h
hphp/runtime/base/proxy-array.cpp
hphp/runtime/base/proxy-array.h
hphp/runtime/base/type-array.cpp
hphp/runtime/base/type-array.h
hphp/runtime/base/type-object.cpp
hphp/runtime/base/type-object.h
hphp/runtime/base/type-variant.cpp
hphp/runtime/base/type-variant.h
hphp/runtime/ext/ext_sqlite3.cpp
hphp/runtime/ext/ext_xml.cpp
hphp/runtime/ext/filter/logical_filters.cpp
hphp/runtime/ext/soap/encoding.cpp
hphp/runtime/vm/bytecode.cpp
hphp/runtime/vm/name-value-table-wrapper.cpp
hphp/runtime/vm/name-value-table-wrapper.h