| commit | 13388a52b9fbfcd377fdb2c41cbb6b8217df3878 | |
| author | Lucian Wischik <ljw@fb.com> | |
| Fri, 24 Apr 2020 05:39:37 +0000 (23 22:39 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 30 Apr 2020 21:16:26 +0000 (30 14:16 -0700) | ||
| tree | cb5ab03bbc353c9d7b5778ae3adf686cc209113b | treesnapshot (tar.gz zip) |
| parent | 8db5b2a43e5493c21eca59675bf5165e76d27595 | commitdiff |
3/12 don't use lazy in Naming_sqlite
Summary:
This diff stack gets rid of global sharedmem state "NamingTableDatabaseSettings", which stores the path to the naming DB.
In this diff, we had been using "lazy" to represent the handle to the Sqlite3.db. Lazy is a nice thing, sure, but it's getting in the way of my ability to refactor the code. So I'm refactoring it to no longer use Lazy.
Reviewed By: arxanas
Differential Revision: D21191770
fbshipit-source-id: c7a7a2b993e2ef8798fb438d80653af8546b626b
Summary:
This diff stack gets rid of global sharedmem state "NamingTableDatabaseSettings", which stores the path to the naming DB.
In this diff, we had been using "lazy" to represent the handle to the Sqlite3.db. Lazy is a nice thing, sure, but it's getting in the way of my ability to refactor the code. So I'm refactoring it to no longer use Lazy.
Reviewed By: arxanas
Differential Revision: D21191770
fbshipit-source-id: c7a7a2b993e2ef8798fb438d80653af8546b626b
| hphp/hack/src/naming/naming_sqlite.ml | diffblobblamehistory |